Skip to content

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
Signed-off-by: Rafael Raposo <[email protected]>
  • Loading branch information
RRap0so committed Sep 30, 2024
1 parent ea164b7 commit 358151e
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 13 deletions.
2 changes: 1 addition & 1 deletion flyteadmin/pkg/rpc/adminservice/base.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func NewAdminServer(ctx context.Context, pluginRegistry *plugins.Registry, confi
go func() {
executionEventWriter.Run()
}()

Check warning on line 84 in flyteadmin/pkg/rpc/adminservice/base.go

View check run for this annotation

Codecov / codecov/patch

flyteadmin/pkg/rpc/adminservice/base.go#L81-L84

Added lines #L81 - L84 were not covered by tests

workflowExecutor := workflowengineImpl.NewK8sWorkflowExecutor(configuration, execCluster, workflowBuilder, dataStorageClient, executionEventWriter)

Check warning on line 86 in flyteadmin/pkg/rpc/adminservice/base.go

View check run for this annotation

Codecov / codecov/patch

flyteadmin/pkg/rpc/adminservice/base.go#L86

Added line #L86 was not covered by tests
logger.Info(ctx, "Successfully created a workflow executor engine")
pluginRegistry.RegisterDefault(plugins.PluginIDWorkflowExecutor, workflowExecutor)
Expand Down
9 changes: 5 additions & 4 deletions flyteadmin/pkg/workflowengine/impl/k8s_executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ package impl
import (
"context"

"google.golang.org/grpc/codes"
"google.golang.org/protobuf/types/known/timestamppb"
k8apierr "k8s.io/apimachinery/pkg/api/errors"
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"

eventsInterfaces "github.com/flyteorg/flyte/flyteadmin/pkg/async/events/interfaces"
"github.com/flyteorg/flyte/flyteadmin/pkg/errors"
"github.com/flyteorg/flyte/flyteadmin/pkg/executioncluster"
Expand All @@ -14,10 +19,6 @@ import (
"github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/event"
"github.com/flyteorg/flyte/flytestdlib/logger"
"github.com/flyteorg/flyte/flytestdlib/storage"
"google.golang.org/grpc/codes"
"google.golang.org/protobuf/types/known/timestamppb"
k8apierr "k8s.io/apimachinery/pkg/api/errors"
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

var deletePropagationBackground = v1.DeletePropagationBackground
Expand Down
18 changes: 10 additions & 8 deletions flyteadmin/pkg/workflowengine/impl/k8s_executor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,16 @@ package impl
import (
"context"
"errors"
"regexp"
"testing"

"github.com/golang/protobuf/proto"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
k8apierr "k8s.io/apimachinery/pkg/api/errors"
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime/schema"

eventMock "github.com/flyteorg/flyte/flyteadmin/pkg/async/events/mocks"
"github.com/flyteorg/flyte/flyteadmin/pkg/executioncluster"
execClusterIfaces "github.com/flyteorg/flyte/flyteadmin/pkg/executioncluster/interfaces"
Expand All @@ -18,14 +28,6 @@ import (
flyteclient "github.com/flyteorg/flyte/flytepropeller/pkg/client/clientset/versioned"
v1alpha12 "github.com/flyteorg/flyte/flytepropeller/pkg/client/clientset/versioned/typed/flyteworkflow/v1alpha1"
"github.com/flyteorg/flyte/flytestdlib/storage"
"github.com/golang/protobuf/proto"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
k8apierr "k8s.io/apimachinery/pkg/api/errors"
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime/schema"
"regexp"
"testing"
)

var fakeFlyteWF = FakeFlyteWorkflowV1alpha1{}
Expand Down

0 comments on commit 358151e

Please sign in to comment.