-
Notifications
You must be signed in to change notification settings - Fork 671
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Flyte-core flyteadmin / datacatalog expose ports (#5013)
- Flyteadmin setting for the grpc port is nested and grpcPort should not be used. Address incorrect config / documentation - Both flyteadmin and datacatalog have configurable ports to use for HTTP and GRPC, but the k8s spec for the containers doesn't expose matching ports. Fix that! Signed-off-by: ddl-ebrown <[email protected]>
- Loading branch information
1 parent
a5e2733
commit 361e1ef
Showing
22 changed files
with
180 additions
and
165 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,7 +81,7 @@ flyteadmin: | |
- configMap: | ||
name: sslcerts # name of the ca-certificates.crt configmap in the cluster | ||
name: sslcerts | ||
additionalVolumeMounts: | ||
additionalVolumeMounts: | ||
- mountPath: /etc/ssl/certs/ # where to mount the above certificate | ||
name: sslcerts | ||
# -- Appends extra command line arguments to the serve command | ||
|
@@ -459,11 +459,11 @@ configmap: | |
console: | ||
BASE_URL: /console | ||
CONFIG_DIR: /etc/flyte/config | ||
|
||
logger: | ||
show-source: true | ||
level: 6 | ||
|
||
# -- Domains configuration for Flyte projects. This enables the specified number of domains across all projects in Flyte. | ||
domain: | ||
domains: | ||
|
@@ -485,7 +485,8 @@ configmap: | |
# Refer to the [server config](https://pkg.go.dev/github.com/lyft/[email protected]/pkg/config#ServerConfig). | ||
server: | ||
httpPort: 8088 | ||
grpcPort: 8089 | ||
grpc: | ||
port: 8089 | ||
security: | ||
# -- Controls whether to serve requests over SSL/TLS. | ||
secure: false | ||
|
@@ -552,7 +553,7 @@ configmap: | |
- profile | ||
- openid | ||
- offline_access | ||
clientId: <clientid declared in IDP for the UI access> | ||
clientId: <clientid declared in IDP for the UI access> | ||
|
||
# -- Datacatalog server config | ||
datacatalogServer: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -626,7 +626,8 @@ configmap: | |
# Refer to the [server config](https://pkg.go.dev/github.com/lyft/[email protected]/pkg/config#ServerConfig). | ||
server: | ||
httpPort: 8088 | ||
grpcPort: 8089 | ||
grpc: | ||
port: 8089 | ||
security: | ||
# -- Controls whether to serve requests over SSL/TLS. | ||
secure: false | ||
|
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -377,7 +377,8 @@ flyte: | |
# Refer to the [server config](https://pkg.go.dev/github.com/lyft/[email protected]/pkg/config#ServerConfig). | ||
server: | ||
httpPort: 8088 | ||
grpcPort: 8089 | ||
grpc: | ||
port: 8089 | ||
security: | ||
# -- Controls whether to serve requests over SSL/TLS. | ||
secure: false | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.