Skip to content

Commit

Permalink
nit
Browse files Browse the repository at this point in the history
Signed-off-by: Kevin Su <[email protected]>
  • Loading branch information
pingsutw committed Aug 8, 2024
1 parent 827d55b commit 46b721b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion flyteadmin/pkg/manager/impl/util/shared.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import (
)

func GetExecutionName(request admin.ExecutionCreateRequest) string {

if request.Name != "" {
return request.Name
}
Expand Down
2 changes: 1 addition & 1 deletion flytepropeller/pkg/compiler/transformers/k8s/inputs.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func validateInputs(nodeID common.NodeID, iface *core.TypedInterface, inputs cor

inputType := validators.LiteralTypeForLiteral(inputVal)
if !validators.AreTypesCastable(inputType, v.Type) {
errs.Collect(errors.NewMismatchingTypesErr(nodeID, inputVar, inputType.String(), "", v.Type.String()))
errs.Collect(errors.NewMismatchingTypesErr(nodeID, inputVar, v.Type.String(), "", inputType.String()))
continue
}

Expand Down

0 comments on commit 46b721b

Please sign in to comment.