Skip to content

Commit

Permalink
adding IsArray flag to NodeExecutionMetadata
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Rammer <[email protected]>
  • Loading branch information
hamersaw committed Oct 4, 2023
1 parent 54902c7 commit 4a80465
Show file tree
Hide file tree
Showing 44 changed files with 1,016 additions and 541 deletions.
4 changes: 4 additions & 0 deletions flyteadmin/pkg/repositories/transformers/node_execution.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ func CreateNodeExecutionModel(ctx context.Context, input ToNodeExecutionModelInp
SpecNodeId: input.Request.Event.SpecNodeId,
IsParentNode: input.Request.Event.IsParent,
IsDynamic: input.Request.Event.IsDynamic,
IsArray: input.Request.Event.IsArray,
}
err := handleNodeExecutionInputs(ctx, nodeExecution, input.Request, input.StorageClient)
if err != nil {
Expand Down Expand Up @@ -304,6 +305,9 @@ func UpdateNodeExecutionModel(
if request.Event.IsDynamic {
nodeExecutionMetadata.IsDynamic = true
}
if request.Event.IsArray {
nodeExecutionMetadata.IsArray = true
}

Check warning on line 310 in flyteadmin/pkg/repositories/transformers/node_execution.go

View check run for this annotation

Codecov / codecov/patch

flyteadmin/pkg/repositories/transformers/node_execution.go#L309-L310

Added lines #L309 - L310 were not covered by tests
nodeExecMetadataBytes, err := proto.Marshal(&nodeExecutionMetadata)
if err != nil {
return errors.NewFlyteAdminErrorf(codes.Internal,
Expand Down
157 changes: 99 additions & 58 deletions flyteidl/gen/pb-cpp/flyteidl/admin/node_execution.pb.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions flyteidl/gen/pb-cpp/flyteidl/admin/node_execution.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 4a80465

Please sign in to comment.