Skip to content

Commit

Permalink
Fix datacatalog
Browse files Browse the repository at this point in the history
Signed-off-by: Eduardo Apolinario <[email protected]>
  • Loading branch information
eapolinario committed Jan 31, 2024
1 parent ec7b0a3 commit 4af2304
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
3 changes: 3 additions & 0 deletions datacatalog/.golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,6 @@ linters-settings:
- default
- prefix(github.com/flyteorg)
skip-generated: true
issues:
exclude:
- copylocks
6 changes: 3 additions & 3 deletions datacatalog/pkg/manager/impl/artifact_manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,23 @@ import (
stdErrors "errors"
"fmt"
"os"
"reflect"
"testing"
"time"
"reflect"

"github.com/golang/protobuf/proto"
"github.com/golang/protobuf/ptypes"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
"github.com/flyteorg/flyte/datacatalog/pkg/repositories/transformers"

"github.com/flyteorg/flyte/datacatalog/pkg/common"
"github.com/flyteorg/flyte/datacatalog/pkg/errors"
repoErrors "github.com/flyteorg/flyte/datacatalog/pkg/repositories/errors"
"github.com/flyteorg/flyte/datacatalog/pkg/repositories/mocks"
"github.com/flyteorg/flyte/datacatalog/pkg/repositories/models"
"github.com/flyteorg/flyte/datacatalog/pkg/repositories/transformers"
"github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/core"
"github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/datacatalog"
"github.com/flyteorg/flyte/flytestdlib/contextutils"
Expand Down Expand Up @@ -657,7 +658,6 @@ func TestUpdateArtifact(t *testing.T) {
reflect.DeepEqual(artifact.SerializedMetadata, serializedMetadata)
})).Return(nil)


request := &datacatalog.UpdateArtifactRequest{
Dataset: expectedDataset.Id,
QueryHandle: &datacatalog.UpdateArtifactRequest_ArtifactId{
Expand Down
2 changes: 1 addition & 1 deletion datacatalog/pkg/repositories/errors/postgres.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ package errors
import (
"errors"
"fmt"
"github.com/flyteorg/flyte/flytestdlib/database"
"reflect"

"github.com/jackc/pgconn"
"google.golang.org/grpc/codes"
"gorm.io/gorm"

catalogErrors "github.com/flyteorg/flyte/datacatalog/pkg/errors"
"github.com/flyteorg/flyte/flytestdlib/database"
"github.com/flyteorg/flyte/flytestdlib/logger"
)

Expand Down
2 changes: 1 addition & 1 deletion datacatalog/pkg/repositories/initialize.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ package repositories

import (
"context"
"github.com/flyteorg/flyte/flytestdlib/database"
"reflect"

errors2 "github.com/flyteorg/flyte/datacatalog/pkg/repositories/errors"
"github.com/flyteorg/flyte/datacatalog/pkg/runtime"
"github.com/flyteorg/flyte/flytestdlib/database"
"github.com/flyteorg/flyte/flytestdlib/logger"
"github.com/flyteorg/flyte/flytestdlib/promutils"
)
Expand Down

0 comments on commit 4af2304

Please sign in to comment.