Review comments

flyteorg · Oct 18, 2024 · 4d0ee5d · 4d0ee5d
1 parent 0a12e95
commit 4d0ee5d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go b/flyteplugins/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go
@@ -146,7 +146,7 @@ func (e *earliestFileErrorReader) IsError(ctx context.Context) (bool, error) {
 }
 
 func (e *earliestFileErrorReader) ReadError(ctx context.Context) (io.ExecutionError, error) {
-	var earliestTimestamp time.Time = time.Now()
+	var earliestTimestamp *time.Time = nil
 	earliestExecutionError := io.ExecutionError{}
 	const maxItems = 1000
 	cursor := storage.NewCursorAtStart()
@@ -167,9 +167,9 @@ func (e *earliestFileErrorReader) ReadError(ctx context.Context) (io.ExecutionEr
 				return io.ExecutionError{}, errors.Wrapf(err, "failed to read error file @[%s]", errorFilePath.String())
 			}
 			timestamp := errorDoc.Error.GetTimestamp().AsTime()
-			if earliestTimestamp.After(timestamp) {
+			if earliestTimestamp == nil || earliestTimestamp.After(timestamp) {
 				earliestExecutionError = errorDoc2ExecutionError(errorDoc, errorFilePath)
-				earliestTimestamp = timestamp
+				earliestTimestamp = &timestamp
 			}
 		}
 	}