Skip to content

Commit

Permalink
better comments
Browse files Browse the repository at this point in the history
Signed-off-by: Future-Outlier <[email protected]>
  • Loading branch information
Future-Outlier committed Dec 17, 2024
1 parent 25fea29 commit 4e24e91
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions flytepropeller/pkg/controller/nodes/task/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ func (t Handler) invokePlugin(ctx context.Context, p pluginCore.Plugin, tCtx *ta
// is actually present.
switch pluginTrns.pInfo.Phase() {
case pluginCore.PhaseSuccess:
// This is to prevent the console from potentially checking the deck URI that does not exist if in final phase(PhaseSuccess).
// This is for backward compatibility with older Flytekit versions.
if !deckEnabled {
err = pluginTrns.AddDeckURIIfDeckExists(ctx, tCtx)
}
Expand Down Expand Up @@ -600,8 +600,7 @@ func (t Handler) invokePlugin(ctx context.Context, p pluginCore.Plugin, tCtx *ta
case pluginCore.PhaseRetryableFailure:
fallthrough
case pluginCore.PhasePermanentFailure:
// This is to prevent the console from potentially checking the deck URI that does not exist if in final
// phase(PhaseFailure).
// This is for backward compatibility with older Flytekit versions.
if !deckEnabled {
err = pluginTrns.AddDeckURIIfDeckExists(ctx, tCtx)
}
Expand Down

0 comments on commit 4e24e91

Please sign in to comment.