fixed semconv issue

Signed-off-by: Daniel Rammer <[email protected]>
flyteorg · Nov 3, 2023 · 4f8a8f1 · 4f8a8f1
1 parent 9f248d1
commit 4f8a8f1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/flytepropeller/pkg/controller/handler.go b/flytepropeller/pkg/controller/handler.go
@@ -374,7 +374,9 @@ func (p *Propeller) streak(ctx context.Context, w *v1alpha1.FlyteWorkflow, wfClo
 	// update the GetExecutionStatus block of the FlyteWorkflow resource. UpdateStatus will not
 	// allow changes to the Spec of the resource, which is ideal for ensuring
 	// nothing other than resource status has been updated.
+	_, wfStoreUpdateSpan := otelutils.NewSpan(ctx, otelutils.FlytePropellerTracer, "WorkflowStore.Update")
 	newWf, updateErr := p.wfStore.Update(ctx, mutatedWf, workflowstore.PriorityClassCritical)
+	wfStoreUpdateSpan.End()
 	if updateErr != nil {
 		// The update has failed, lets check if this is because the size is too large. If so
 		if workflowstore.IsWorkflowTooLarge(updateErr) {

diff --git a/flytestdlib/otelutils/factory.go b/flytestdlib/otelutils/factory.go
@@ -12,7 +12,7 @@ import (
 	"go.opentelemetry.io/otel/exporters/stdout/stdouttrace"
 	"go.opentelemetry.io/otel/sdk/resource"
 	"go.opentelemetry.io/otel/sdk/trace"
-	semconv "go.opentelemetry.io/otel/semconv/v1.12.0"
+	semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
 	rawtrace "go.opentelemetry.io/otel/trace"
 )