Set Secure flag only if Secure is set on flyteadmin config

Signed-off-by: Eduardo Apolinario <[email protected]>

flyteadmin/auth/cookie.go

@@ -12,6 +12,7 @@ import (
 	"github.com/gorilla/securecookie"
 
 	"github.com/flyteorg/flyte/flyteadmin/auth/interfaces"
+	"github.com/flyteorg/flyte/flyteadmin/pkg/config"
 	"github.com/flyteorg/flyte/flytestdlib/errors"
 	"github.com/flyteorg/flyte/flytestdlib/logger"
 )
@@ -69,7 +70,7 @@ func NewSecureCookie(cookieName, value string, hashKey, blockKey []byte, domain
 		Domain:   domain,
 		SameSite: sameSiteMode,
 		HttpOnly: true,
-		Secure:   true,
+		Secure:   config.GetConfig().Security.Secure,
 	}, nil
 }
 
@@ -128,7 +129,7 @@ func NewCsrfCookie() http.Cookie {
 		Value:    csrfStateToken,
 		SameSite: http.SameSiteLaxMode,
 		HttpOnly: true,
-		Secure:   true,
+		Secure:   config.GetConfig().Security.Secure,
 	}
 }
 

flyteadmin/auth/cookie_manager.go

@@ -11,6 +11,7 @@ import (
 	"golang.org/x/oauth2"
 
 	"github.com/flyteorg/flyte/flyteadmin/auth/config"
+	serverConfig "github.com/flyteorg/flyte/flyteadmin/pkg/config"
 	"github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/service"
 	"github.com/flyteorg/flyte/flytestdlib/errors"
 	"github.com/flyteorg/flyte/flytestdlib/logger"
@@ -218,7 +219,7 @@ func (c *CookieManager) getLogoutCookie(name string) *http.Cookie {
 		Domain:   c.domain,
 		MaxAge:   0,
 		HttpOnly: true,
-		Secure:   true,
+		Secure:   serverConfig.GetConfig().Security.Secure,
 		Expires:  time.Now().Add(-1 * time.Hour),
 	}
 }