Skip to content

Commit

Permalink
Update container builds from go 1.21.5 to latest
Browse files Browse the repository at this point in the history
 - go 1.21.5 was released on 12-5-2023 and go 1.21.8 was released on
   3-5-2024. During that time a number of high and critical vulns have
   been addressed

 - This PR changes the build process to float with the latest go release
   to automatically pick up remediated vulnerabilities rather than pin
   to a specific go release

 - Ideally there would be a renovate or dependabot process that
   automatically puts up PRs to this repo to update the pinning, which
   is safer from a build / test perspective.  Without that process in
   place, it's probably better to float with the latest patch release of
   go 1.21

Signed-off-by: ddl-ebrown <[email protected]>
  • Loading branch information
ddl-ebrown committed Mar 22, 2024
1 parent b6f35ad commit 64e9f38
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ ARG FLYTECONSOLE_VERSION=latest
FROM ghcr.io/flyteorg/flyteconsole:${FLYTECONSOLE_VERSION} AS flyteconsole


FROM --platform=${BUILDPLATFORM} golang:1.21.5-bookworm AS flytebuilder
FROM --platform=${BUILDPLATFORM} golang:1.21-bookworm AS flytebuilder

ARG TARGETARCH
ENV GOARCH "${TARGETARCH}"
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.datacatalog
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# WARNING: THIS FILE IS MANAGED IN THE 'BOILERPLATE' REPO AND COPIED TO OTHER REPOSITORIES.
# ONLY EDIT THIS FILE FROM WITHIN THE 'FLYTEORG/BOILERPLATE' REPOSITORY:
#
#
# TO OPT OUT OF UPDATES, SEE https://github.com/flyteorg/boilerplate/blob/master/Readme.rst

FROM --platform=${BUILDPLATFORM} golang:1.21.5-alpine3.18 as builder
FROM --platform=${BUILDPLATFORM} golang:1.21-alpine3.18 as builder

ARG TARGETARCH
ENV GOARCH "${TARGETARCH}"
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.flyteadmin
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# WARNING: THIS FILE IS MANAGED IN THE 'BOILERPLATE' REPO AND COPIED TO OTHER REPOSITORIES.
# ONLY EDIT THIS FILE FROM WITHIN THE 'LYFT/BOILERPLATE' REPOSITORY:
#
#
# TO OPT OUT OF UPDATES, SEE https://github.com/lyft/boilerplate/blob/master/Readme.rst

FROM --platform=${BUILDPLATFORM} golang:1.21.5-alpine3.18 as builder
FROM --platform=${BUILDPLATFORM} golang:1.21-alpine3.18 as builder

ARG TARGETARCH
ENV GOARCH "${TARGETARCH}"
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.flytecopilot
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# WARNING: THIS FILE IS MANAGED IN THE 'BOILERPLATE' REPO AND COPIED TO OTHER REPOSITORIES.
# ONLY EDIT THIS FILE FROM WITHIN THE 'LYFT/BOILERPLATE' REPOSITORY:
#
#
# TO OPT OUT OF UPDATES, SEE https://github.com/lyft/boilerplate/blob/master/Readme.rst

FROM --platform=${BUILDPLATFORM} golang:1.21.5-alpine3.18 as builder
FROM --platform=${BUILDPLATFORM} golang:1.21-alpine3.18 as builder

ARG TARGETARCH
ENV GOARCH "${TARGETARCH}"
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.flytepropeller
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# WARNING: THIS FILE IS MANAGED IN THE 'BOILERPLATE' REPO AND COPIED TO OTHER REPOSITORIES.
# ONLY EDIT THIS FILE FROM WITHIN THE 'LYFT/BOILERPLATE' REPOSITORY:
#
#
# TO OPT OUT OF UPDATES, SEE https://github.com/lyft/boilerplate/blob/master/Readme.rst

FROM --platform=${BUILDPLATFORM} golang:1.21.5-alpine3.18 as builder
FROM --platform=${BUILDPLATFORM} golang:1.21-alpine3.18 as builder

ARG TARGETARCH
ENV GOARCH "${TARGETARCH}"
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.flytescheduler
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# WARNING: THIS FILE IS MANAGED IN THE 'BOILERPLATE' REPO AND COPIED TO OTHER REPOSITORIES.
# ONLY EDIT THIS FILE FROM WITHIN THE 'LYFT/BOILERPLATE' REPOSITORY:
#
#
# TO OPT OUT OF UPDATES, SEE https://github.com/lyft/boilerplate/blob/master/Readme.rst

FROM --platform=${BUILDPLATFORM} golang:1.21.5-alpine3.18 as builder
FROM --platform=${BUILDPLATFORM} golang:1.21-alpine3.18 as builder

ARG TARGETARCH
ENV GOARCH "${TARGETARCH}"
Expand Down

0 comments on commit 64e9f38

Please sign in to comment.