add a commment

Signed-off-by: Yee Hing Tong <[email protected]>
flyteorg · Jun 24, 2024 · 66f6bfd · 66f6bfd
1 parent 9e47cc5
commit 66f6bfd
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 4 deletions.
diff --git a/flyteidl/clients/go/assets/admin.swagger.json b/flyteidl/clients/go/assets/admin.swagger.json
diff --git a/flyteidl/gen/pb-es/flyteidl/event/event_pb.ts b/flyteidl/gen/pb-es/flyteidl/event/event_pb.ts
diff --git a/flyteidl/gen/pb-go/flyteidl/event/event.pb.go b/flyteidl/gen/pb-go/flyteidl/event/event.pb.go
diff --git a/flyteidl/gen/pb-go/gateway/flyteidl/service/admin.swagger.json b/flyteidl/gen/pb-go/gateway/flyteidl/service/admin.swagger.json
diff --git a/flyteidl/gen/pb_rust/flyteidl.event.rs b/flyteidl/gen/pb_rust/flyteidl.event.rs
diff --git a/flyteidl/protos/flyteidl/event/event.proto b/flyteidl/protos/flyteidl/event/event.proto
@@ -115,12 +115,14 @@ message NodeExecutionEvent {
     // Indicates if this node is an ArrayNode.
     bool is_array = 22;
 
+    // Holding this field here for now, this will be upstreamed soon.
     // So that Admin doesn't have to rebuild the node execution graph to find the target entity, propeller will fill this
     // in optionally - currently this is only filled in for subworkflows. This is the ID of the subworkflow corresponding
     // to this node execution. It is difficult to find because Admin only sees one node at a time. A subworkflow could be
     // nested multiple layers deep, and you'd need to access the correct workflow template to know the target subworkflow.
     core.Identifier target_entity = 23;
 
+    // Holding this field here for now, this will be upstreamed soon.
     // Tasks and subworkflows (but not launch plans) that are run within a dynamic task are effectively independent of
     // the tasks that are registered in Admin's db. Confusingly, they are often identical, but sometimes they are not
     // even registered at all. Similar to the target_entity field, at the time Admin receives this event, it has no idea