Skip to content

Commit

Permalink
fix unit tests and lint
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Rammer <[email protected]>
  • Loading branch information
hamersaw committed Jan 17, 2024
1 parent f2b1171 commit 674cdc0
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 103 deletions.
2 changes: 1 addition & 1 deletion flytepropeller/cmd/controller/cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ func executeRootCmd(baseCtx context.Context, cfg *config2.Config) error {
SyncPeriod: &cfg.DownstreamEval.Duration,
DefaultNamespaces: namespaceConfigs,
},
NewCache: executors.NewCache,
NewCache: executors.NewCache,
NewClient: executors.NewClient,
Metrics: metricsserver.Options{
// Disable metrics serving
Expand Down
2 changes: 1 addition & 1 deletion flytepropeller/cmd/controller/cmd/webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ func runWebhook(origContext context.Context, propellerCfg *config.Config, cfg *w
SyncPeriod: &propellerCfg.DownstreamEval.Duration,
DefaultNamespaces: namespaceConfigs,
},
NewCache: executors.NewCache,
NewCache: executors.NewCache,
NewClient: executors.NewClient,
Metrics: metricsserver.Options{
// Disable metrics serving
Expand Down
1 change: 0 additions & 1 deletion flytepropeller/pkg/controller/executors/kube.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ type fallbackClientReader struct {
orderedClients []client.Reader
}


func (c fallbackClientReader) Get(ctx context.Context, key client.ObjectKey, out client.Object, opts ...client.GetOption) (err error) {
for _, k8sClient := range c.orderedClients {
if err = k8sClient.Get(ctx, key, out, opts...); err == nil {
Expand Down
100 changes: 0 additions & 100 deletions flytepropeller/pkg/controller/executors/mocks/client_builder.go

This file was deleted.

0 comments on commit 674cdc0

Please sign in to comment.