Skip to content

Commit

Permalink
minor change
Browse files Browse the repository at this point in the history
Signed-off-by: Kevin Su <[email protected]>
  • Loading branch information
pingsutw committed Oct 18, 2023
1 parent b0ab79e commit 6c4dc83
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion flytepropeller/pkg/controller/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ func StartController(ctx context.Context, cfg *config.Config, defaultNamespace s
return errors.Wrapf(err, "error building Kubernetes Clientset")
}

resolver.Register(k8sResolver.NewBuilder(ctx, kubeClient, k8sResolver.K8sSchema))
resolver.Register(k8sResolver.NewBuilder(ctx, kubeClient, k8sResolver.Schema))

Check warning on line 558 in flytepropeller/pkg/controller/controller.go

View check run for this annotation

Codecov / codecov/patch

flytepropeller/pkg/controller/controller.go#L557-L558

Added lines #L557 - L558 were not covered by tests
flyteworkflowClient, err := clientset.NewForConfig(kubecfg)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions flytestdlib/resolver/k8s_resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
)

const (
K8sSchema = "k8s"
Schema = "k8s"
)

type targetInfo struct {
Expand All @@ -28,7 +28,7 @@ type targetInfo struct {
}

func (t targetInfo) String() string {
return fmt.Sprintf("%s:///%s.%s:%s", K8sSchema, t.serviceNamespace, t.serviceName, t.port)
return fmt.Sprintf("%s:///%s.%s:%s", Schema, t.serviceNamespace, t.serviceName, t.port)
}

// NewBuilder creates a kubeBuilder which is used by grpc resolver.
Expand Down
2 changes: 1 addition & 1 deletion flytestdlib/resolver/k8s_resolver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func TestBuilder(t *testing.T) {
}

// Make sure watcher is started before we create the endpoint
time.Sleep(5 * time.Second)
time.Sleep(2 * time.Second)

_, err = k8sClient.CoreV1().Endpoints("flyte").Create(context.Background(), &v1.Endpoints{
ObjectMeta: metav1.ObjectMeta{
Expand Down

0 comments on commit 6c4dc83

Please sign in to comment.