Skip to content

Commit

Permalink
better url reference
Browse files Browse the repository at this point in the history
Signed-off-by: Future-Outlier <[email protected]>
  • Loading branch information
Future-Outlier committed Sep 16, 2024
1 parent da9ff1a commit 7a3a109
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rfc/system/5741-binary-idl-with-message-pack.md
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ Notes:
- We can explore all MessagePack implementations for Golang at the [MessagePack official website](https://msgpack.org/index.html).

2. **Library Comparison**:
- The library [github.com/vmihailenco/msgpack](https://github.com/vmihailenco/msgpack) doesn't support strict type deserialization (for example, `map[int]string`), but `"github.com/shamaton/msgpack/v2"` supports this feature. This is super important for backward copmatibility.
- The library [github.com/vmihailenco/msgpack](https://github.com/vmihailenco/msgpack) doesn't support strict type deserialization (for example, `map[int]string`), but [github.com/shamaton/msgpack/v2](https://github.com/shamaton/msgpack) supports this feature. This is super important for backward copmatibility.

3. **Library Popularity**:
- While [github.com/shamaton/msgpack/v2](https://github.com/shamaton/msgpack) has fewer stars on GitHub, it has proven to be reliable in various test cases. All cases created by me have passed successfully, which you can find in this [pull request](https://github.com/flyteorg/flytekit/pull/2751).
Expand All @@ -167,7 +167,7 @@ Notes:
- [github.com/shamaton/msgpack/v2](https://github.com/shamaton/msgpack) is still an actively maintained project. The author responds quickly to issues and questions, making it a well-supported choice for projects requiring ongoing maintenance and active support.

5. **Testing Process**:
- I initially started with [github.com/vmihailenco/msgpack](https://github.com/vmihailenco/msgpack) but switched to `"github.com/shamaton/msgpack/v2"` due to its better support for strict typing and the active support provided by the author.
- I initially started with [github.com/vmihailenco/msgpack](https://github.com/vmihailenco/msgpack) but switched to [github.com/shamaton/msgpack/v2](https://github.com/shamaton/msgpack) due to its better support for strict typing and the active support provided by the author.


##### JavaScript
Expand Down

0 comments on commit 7a3a109

Please sign in to comment.