Skip to content

Commit

Permalink
Remove uses of validate in flyteadmin
Browse files Browse the repository at this point in the history
Signed-off-by: Eduardo Apolinario <[email protected]>
  • Loading branch information
eapolinario committed Dec 27, 2023
1 parent 8a8e47d commit 7db165e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
5 changes: 0 additions & 5 deletions flyteadmin/pkg/manager/impl/validation/execution_validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,6 @@ func ValidateExecutionRequest(ctx context.Context, request admin.ExecutionCreate
return err
}
}
// TODO: Remove redundant validation with the rest of the method.
// This final call to validating the request ensures the notification types are expected.
if err := request.Validate(); err != nil {
return err
}
return nil
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,6 @@ func ValidateLaunchPlan(ctx context.Context,
return err
}
}
// TODO: Remove redundant validation that occurs with launch plan and the validate method for the message.
// Ensure the notification types are validated.
if err := request.Validate(); err != nil {
return err
}
return nil
}

Expand Down

0 comments on commit 7db165e

Please sign in to comment.