Skip to content

Commit

Permalink
Using new offloaded metadata literal message for literal offloading (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
pmahindrakar-oss committed Sep 9, 2024
1 parent 9c30e61 commit 845a6f2
Show file tree
Hide file tree
Showing 11 changed files with 34 additions and 32 deletions.
5 changes: 3 additions & 2 deletions flyteidl/gen/pb-es/flyteidl/core/literals_pb.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions flyteidl/gen/pb-go/flyteidl/core/literals.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions flyteidl/gen/pb_rust/flyteidl.core.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions flyteidl/protos/flyteidl/core/literals.proto
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ message Scalar {

// A simple value. This supports any level of nesting (e.g. array of array of array of Blobs) as well as simple primitives.
message Literal {
reserved 6,7;
reserved 6, 7;
oneof value {
// A simple value.
Scalar scalar = 1;
Expand All @@ -105,6 +105,7 @@ message Literal {
LiteralMap map = 3;

// Offloaded literal metadata
// When you deserialize the offloaded metadata, it would be of Literal and its type would be defined by LiteralType stored in offloaded_metadata.
LiteralOffloadedMetadata offloaded_metadata = 8;
}

Expand All @@ -115,19 +116,17 @@ message Literal {

// Additional metadata for literals.
map<string, string> metadata = 5;


}

// A message that contains the metadata of the offloaded data.
message LiteralOffloadedMetadata {
// The location of the offloaded data.
// The location of the offloaded core.Literal.
string uri = 1;

// The size of the offloaded data.
uint64 size_bytes = 2;

// The literal type of the offloaded data.
// The inferred literal type of the offloaded data.
LiteralType inferred_type = 3;
}

Expand Down

0 comments on commit 845a6f2

Please sign in to comment.