refactor: switch default from opt-in to opt-out

Signed-off-by: Dylan Spagnuolo <[email protected]>
flyteorg · Sep 17, 2024 · 8a7ece0 · 8a7ece0
1 parent 964d975
commit 8a7ece0
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 16 deletions.
diff --git a/docs/deployment/configuration/generated/flyteadmin_config.rst b/docs/deployment/configuration/generated/flyteadmin_config.rst
@@ -2720,7 +2720,7 @@ k8s (`config.K8sPluginConfig`_)
     output-vol-name: flyte-outputs
     start-timeout: 1m40s
     storage: ""
-    add-sys-ptrace-capability: false
+    add-sys-ptrace-capability: true
   create-container-config-error-grace-period: 0s
   create-container-error-grace-period: 3m0s
   default-annotations:
@@ -3041,7 +3041,7 @@ Co-Pilot Configuration
   output-vol-name: flyte-outputs
   start-timeout: 1m40s
   storage: ""
-  add-sys-ptrace-capability: false
+  add-sys-ptrace-capability: true
   
 
 delete-resource-on-finalize (bool)
@@ -3386,7 +3386,7 @@ Used to enable SYS_PTRACE for co-pilot containers
 
 .. code-block:: yaml
 
-  "false"
+  "true"
   
 
 resource.Quantity

diff --git a/docs/deployment/configuration/generated/flytepropeller_config.rst b/docs/deployment/configuration/generated/flytepropeller_config.rst
@@ -1172,7 +1172,7 @@ k8s (`config.K8sPluginConfig`_)
     output-vol-name: flyte-outputs
     start-timeout: 1m40s
     storage: ""
-    add-sys-ptrace-capability: false
+    add-sys-ptrace-capability: true
   create-container-config-error-grace-period: 0s
   create-container-error-grace-period: 3m0s
   default-annotations:
@@ -2522,7 +2522,7 @@ Co-Pilot Configuration
   output-vol-name: flyte-outputs
   start-timeout: 1m40s
   storage: ""
-  add-sys-ptrace-capability: false
+  add-sys-ptrace-capability: true
   
 
 delete-resource-on-finalize (bool)
@@ -2867,7 +2867,7 @@ Used to enable SYS_PTRACE for co-pilot containers
 
 .. code-block:: yaml
 
-  "false"
+  "true"
 
 
 resource.Quantity

diff --git a/docs/deployment/configuration/generated/scheduler_config.rst b/docs/deployment/configuration/generated/scheduler_config.rst
@@ -2720,7 +2720,7 @@ k8s (`config.K8sPluginConfig`_)
     output-vol-name: flyte-outputs
     start-timeout: 1m40s
     storage: ""
-    add-sys-ptrace-capability: false
+    add-sys-ptrace-capability: true
   create-container-config-error-grace-period: 0s
   create-container-error-grace-period: 3m0s
   default-annotations:
@@ -3041,7 +3041,7 @@ Co-Pilot Configuration
   output-vol-name: flyte-outputs
   start-timeout: 1m40s
   storage: ""
-  add-sys-ptrace-capability: false
+  add-sys-ptrace-capability: true
   
 
 delete-resource-on-finalize (bool)
@@ -3386,7 +3386,7 @@ Used to enable SYS_PTRACE for co-pilot containers
 
 .. code-block:: yaml
 
-  "false"
+  "true"
 
 
 resource.Quantity

diff --git a/flyteplugins/go/tasks/pluginmachinery/flytek8s/config/config.go b/flyteplugins/go/tasks/pluginmachinery/flytek8s/config/config.go
@@ -40,7 +40,7 @@ var (
 			OutputVolumeName:       "flyte-outputs",
 			CPU:                    "500m",
 			Memory:                 "128Mi",
-			AddSysPTraceCapability: false,
+			AddSysPTraceCapability: true,
 			StartTimeout: config2.Duration{
 				Duration: time.Second * 100,
 			},

diff --git a/flyteplugins/go/tasks/pluginmachinery/flytek8s/copilot_test.go b/flyteplugins/go/tasks/pluginmachinery/flytek8s/copilot_test.go
@@ -42,7 +42,7 @@ func TestFlyteCoPilotContainer(t *testing.T) {
 		},
 		CPU:                    "1024m",
 		Memory:                 "1024Mi",
-		AddSysPTraceCapability: false,
+		AddSysPTraceCapability: true,
 	}
 
 	t.Run("happy", func(t *testing.T) {
@@ -56,7 +56,7 @@ func TestFlyteCoPilotContainer(t *testing.T) {
 		assert.Equal(t, "/", c.WorkingDir)
 		assert.Equal(t, 2, len(c.Resources.Limits))
 		assert.Equal(t, 2, len(c.Resources.Requests))
-		assert.NotContains(t, c.SecurityContext.Capabilities.Add, pTraceCapability)
+		assert.Contains(t, c.SecurityContext.Capabilities.Add, pTraceCapability)
 	})
 
 	t.Run("happy stow backend", func(t *testing.T) {
@@ -74,7 +74,7 @@ func TestFlyteCoPilotContainer(t *testing.T) {
 		assert.Equal(t, "/", c.WorkingDir)
 		assert.Equal(t, 2, len(c.Resources.Limits))
 		assert.Equal(t, 2, len(c.Resources.Requests))
-		assert.NotContains(t, c.SecurityContext.Capabilities.Add, pTraceCapability)
+		assert.Contains(t, c.SecurityContext.Capabilities.Add, pTraceCapability)
 	})
 
 	t.Run("happy-vols", func(t *testing.T) {
@@ -111,12 +111,12 @@ func TestFlyteCoPilotContainer(t *testing.T) {
 		cfg.Memory = old
 	})
 
-	t.Run("sys-ptrace-add", func(t *testing.T) {
+	t.Run("no-sys-ptrace-add", func(t *testing.T) {
 		old := cfg.AddSysPTraceCapability
-		cfg.AddSysPTraceCapability = true
+		cfg.AddSysPTraceCapability = false
 		c, err := FlyteCoPilotContainer("x", cfg, []string{"hello"})
 		assert.NoError(t, err)
-		assert.Contains(t, c.SecurityContext.Capabilities.Add, pTraceCapability)
+		assert.NotContains(t, c.SecurityContext.Capabilities.Add, pTraceCapability)
 		cfg.AddSysPTraceCapability = old
 	})
 }