Update to go 1.21 (#4534)

* Update to go 1.21 Signed-off-by: Eduardo Apolinario <[email protected]> * Update go version in dockerfiles Signed-off-by: Eduardo Apolinario <[email protected]> * Use alpine 3.18 in component images Signed-off-by: Eduardo Apolinario <[email protected]> * Update other references to go 1.19 Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
flyteorg · Dec 11, 2023 · 8cc422e · 8cc422e
1 parent a5a9509
commit 8cc422e
Show file tree

Hide file tree

Showing 29 changed files with 196 additions and 31 deletions.
diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
@@ -10,7 +10,7 @@ on:
     branches:
       - master
 env:
-  GO_VERSION: "1.19"
+  GO_VERSION: "1.21"
   PRIORITIES: "P0"
 jobs:
   unpack-envvars:

diff --git a/.github/workflows/flyteidl-checks.yml b/.github/workflows/flyteidl-checks.yml
@@ -10,7 +10,7 @@ on:
     branches:
       - master
 env:
-  GO_VERSION: "1.19"
+  GO_VERSION: "1.21"
 jobs:
   unpack-envvars:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/generate_flyte_manifest.yml b/.github/workflows/generate_flyte_manifest.yml
@@ -17,7 +17,7 @@ jobs:
           fetch-depth: "0"
       - uses: actions/setup-go@v2
         with:
-          go-version: "1.19"
+          go-version: "1.21"
       - name: Update references
         env:
           VERSION: ${{ github.event.inputs.next-version }}

diff --git a/.github/workflows/single-binary.yml b/.github/workflows/single-binary.yml
@@ -27,7 +27,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: "1.19"
+          go-version: "1.21"
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -18,7 +18,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: "1.19"
+          go-version: "1.21"
       - name: Compile
         run: make compile
       - name: Run tests
@@ -59,7 +59,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: "1.19"
+          go-version: "1.21"
       - name: Kustomize and diff
         run: DELTA_CHECK=true make kustomize
 
@@ -69,6 +69,6 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: "1.19"
+          go-version: "1.21"
       - name: Helm and diff
         run: DELTA_CHECK=true make helm
diff --git a/Dockerfile b/Dockerfile
@@ -2,7 +2,7 @@ ARG FLYTECONSOLE_VERSION=latest
 FROM ghcr.io/flyteorg/flyteconsole:${FLYTECONSOLE_VERSION} AS flyteconsole
 
 
-FROM --platform=${BUILDPLATFORM} golang:1.19.13-bookworm AS flytebuilder
+FROM --platform=${BUILDPLATFORM} golang:1.21.5-bookworm AS flytebuilder
 
 ARG TARGETARCH
 ENV GOARCH "${TARGETARCH}"

diff --git a/Dockerfile.datacatalog b/Dockerfile.datacatalog
@@ -3,7 +3,7 @@
 # 
 # TO OPT OUT OF UPDATES, SEE https://github.com/flyteorg/boilerplate/blob/master/Readme.rst
 
-FROM --platform=${BUILDPLATFORM} golang:1.19-alpine3.16 as builder
+FROM --platform=${BUILDPLATFORM} golang:1.21.5-alpine3.18 as builder
 
 ARG TARGETARCH
 ENV GOARCH "${TARGETARCH}"
@@ -39,7 +39,7 @@ RUN make linux_compile
 ENV PATH="/artifacts:${PATH}"
 
 # This will eventually move to centurylink/ca-certs:latest for minimum possible image size
-FROM alpine:3.16
+FROM alpine:3.18
 LABEL org.opencontainers.image.source=https://github.com/flyteorg/datacatalog
 
 COPY --from=builder /artifacts /bin

diff --git a/Dockerfile.flyteadmin b/Dockerfile.flyteadmin
@@ -3,7 +3,7 @@
 # 
 # TO OPT OUT OF UPDATES, SEE https://github.com/lyft/boilerplate/blob/master/Readme.rst
 
-FROM --platform=${BUILDPLATFORM} golang:1.19-alpine3.16 as builder
+FROM --platform=${BUILDPLATFORM} golang:1.21.5-alpine3.18 as builder
 
 ARG TARGETARCH
 ENV GOARCH "${TARGETARCH}"
@@ -39,7 +39,7 @@ RUN make linux_compile
 ENV PATH="/artifacts:${PATH}"
 
 # This will eventually move to centurylink/ca-certs:latest for minimum possible image size
-FROM alpine:3.16
+FROM alpine:3.18
 LABEL org.opencontainers.image.source https://github.com/flyteorg/flyteadmin
 
 COPY --from=builder /artifacts /bin

diff --git a/Dockerfile.flytecopilot b/Dockerfile.flytecopilot
@@ -3,7 +3,7 @@
 # 
 # TO OPT OUT OF UPDATES, SEE https://github.com/lyft/boilerplate/blob/master/Readme.rst
 
-FROM --platform=${BUILDPLATFORM} golang:1.19-alpine3.16 as builder
+FROM --platform=${BUILDPLATFORM} golang:1.21.5-alpine3.18 as builder
 
 ARG TARGETARCH
 ENV GOARCH "${TARGETARCH}"
@@ -29,7 +29,7 @@ RUN make linux_compile
 ENV PATH="/artifacts:${PATH}"
 
 # This will eventually move to centurylink/ca-certs:latest for minimum possible image size
-FROM alpine:3.16
+FROM alpine:3.18
 LABEL org.opencontainers.image.source https://github.com/lyft/flyteplugins
 
 COPY --from=builder /artifacts /bin

diff --git a/Dockerfile.flytepropeller b/Dockerfile.flytepropeller
@@ -3,7 +3,7 @@
 # 
 # TO OPT OUT OF UPDATES, SEE https://github.com/lyft/boilerplate/blob/master/Readme.rst
 
-FROM --platform=${BUILDPLATFORM} golang:1.19-alpine3.16 as builder
+FROM --platform=${BUILDPLATFORM} golang:1.21.5-alpine3.18 as builder
 
 ARG TARGETARCH
 ENV GOARCH "${TARGETARCH}"
@@ -29,7 +29,7 @@ RUN make linux_compile
 ENV PATH="/artifacts:${PATH}"
 
 # This will eventually move to centurylink/ca-certs:latest for minimum possible image size
-FROM alpine:3.16
+FROM alpine:3.18
 LABEL org.opencontainers.image.source https://github.com/flyteorg/flytepropeller
 
 COPY --from=builder /artifacts /bin

diff --git a/Dockerfile.flytescheduler b/Dockerfile.flytescheduler
@@ -3,7 +3,7 @@
 # 
 # TO OPT OUT OF UPDATES, SEE https://github.com/lyft/boilerplate/blob/master/Readme.rst
 
-FROM --platform=${BUILDPLATFORM} golang:1.19-alpine3.16 as builder
+FROM --platform=${BUILDPLATFORM} golang:1.21.5-alpine3.18 as builder
 
 ARG TARGETARCH
 ENV GOARCH "${TARGETARCH}"
@@ -32,7 +32,7 @@ RUN make linux_compile_scheduler
 ENV PATH="/artifacts:${PATH}"
 
 # This will eventually move to centurylink/ca-certs:latest for minimum possible image size
-FROM alpine:3.15
+FROM alpine:3.18
 LABEL org.opencontainers.image.source https://github.com/flyteorg/flyteadmin
 
 COPY --from=builder /artifacts /bin

diff --git a/datacatalog/go.mod b/datacatalog/go.mod
@@ -1,6 +1,6 @@
 module github.com/flyteorg/flyte/datacatalog
 
-go 1.19
+go 1.21
 
 require (
 	github.com/Selvatico/go-mocket v1.0.7