-
Notifications
You must be signed in to change notification settings - Fork 670
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'artifacts-shell' into artifacts
Signed-off-by: Yee Hing Tong <[email protected]>
- Loading branch information
Showing
451 changed files
with
68,153 additions
and
6,845 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,51 +1,51 @@ | ||
<!-- | ||
Thank you for sending the PR! | ||
Please fill the applicable details below | ||
Happy contributing! | ||
--> | ||
|
||
## Tracking issue | ||
_https://github.com/flyteorg/flyte/issues/<number>_ | ||
|
||
<!-- If your PR fixes an open issue, use `Closes #999` to link your PR with the issue. #999 stands for the issue number you are fixing --> | ||
|
||
<!-- Remove this section if not applicable --> | ||
|
||
<!-- Example: Closes #31 --> | ||
|
||
## Docs link | ||
## Why are the changes needed? | ||
|
||
<!-- Add documentation link built by CI jobs here, and specify the changed place --> | ||
<!-- | ||
Please clarify why the changes are needed. For instance, | ||
1. If you propose a new API, clarify the use case for a new API. | ||
2. If you fix a bug, you can clarify why it is a bug. | ||
--> | ||
|
||
## Describe your changes | ||
## What changes were proposed in this pull request? | ||
|
||
<!-- List all the proposed changes in your PR --> | ||
<!-- | ||
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. | ||
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below. | ||
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers. | ||
2. If there is design documentation, please add the link. | ||
--> | ||
|
||
## How was this patch tested? | ||
|
||
<!-- Mark all the applicable boxes. To mark the box as done follow the following conventions --> | ||
<!-- | ||
[x] - Correct; marked as done | ||
[X] - Correct; marked as done | ||
[ ] - Not correct; marked as **not** done | ||
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. | ||
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. | ||
If tests were not added, please describe why they were not added and/or why it was difficult to add. | ||
--> | ||
|
||
### Setup process | ||
|
||
### Screenshots | ||
|
||
## Check all the applicable boxes <!-- Follow the above conventions to check the box --> | ||
|
||
- [ ] I updated the documentation accordingly. | ||
- [ ] All new and existing tests passed. | ||
- [ ] All commits are signed-off. | ||
|
||
## Setup Process | ||
|
||
<!-- Describe how you set up this PR's environment to help maintainers reproduce your results more easily --> | ||
|
||
## Screenshots | ||
|
||
<!-- Add all the screenshots which support your changes --> | ||
|
||
## Note to reviewers | ||
|
||
<!-- Add notes to reviewers if applicable --> | ||
|
||
## Related PRs | ||
|
||
<!-- Add related pull requests for reviewers to check --> | ||
|
||
## Docs link | ||
|
||
<!-- Add documentation link built by CI jobs here, and specify the changed place --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,25 +79,16 @@ jobs: | |
- name: Register P0 tests | ||
if: ${{ inputs.priorities == 'P0' }} | ||
run: | | ||
for f in \ | ||
basics/basics/hello_world.py \ | ||
basics/basics/workflow.py \ | ||
basics/basics/named_outputs.py \ | ||
advanced_composition/advanced_composition/chain_entities.py \ | ||
advanced_composition/advanced_composition/dynamics.py \ | ||
advanced_composition/advanced_composition/map_task.py \ | ||
advanced_composition/advanced_composition/subworkflows.py \ | ||
data_types_and_io/data_types_and_io/dataclass.py \ | ||
data_types_and_io/data_types_and_io/structured_dataset.py ; | ||
while read -r line; | ||
do | ||
pyflyte --config ./boilerplate/flyte/end2end/functional-test-config.yaml \ | ||
register \ | ||
--project flytesnacks \ | ||
--domain development \ | ||
--image cr.flyte.org/flyteorg/flytekit:py3.11-latest \ | ||
--version ${{ env.FLYTESNACKS_VERSION }} \ | ||
flytesnacks/examples/$f; | ||
done | ||
flytesnacks/$line; | ||
done < flytesnacks/flyte_tests.txt | ||
- name: Register all flytesnacks examples | ||
if: ${{ inputs.priorities != 'P0' }} | ||
uses: unionai/[email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ name: Publish flyteidl Buf Package | |
on: | ||
push: | ||
branches: | ||
- artifacts-shell | ||
- artifacts | ||
- master | ||
paths: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,14 +6,6 @@ concurrency: | |
|
||
on: | ||
pull_request: | ||
paths: | ||
- .github/workflows/single-binary.yml | ||
- charts/flyte-binary/** | ||
- charts/flyte-sandbox/** | ||
- cmd/** | ||
- docker/sandbox-bundled/** | ||
- Dockerfile | ||
- go.* | ||
push: | ||
branches: | ||
- master | ||
|
@@ -27,7 +19,7 @@ jobs: | |
- uses: actions/checkout@v3 | ||
- uses: actions/setup-go@v3 | ||
with: | ||
go-version: '1.19' | ||
go-version: "1.21" | ||
- name: golangci-lint | ||
uses: golangci/golangci-lint-action@v3 | ||
with: | ||
|
@@ -129,9 +121,9 @@ jobs: | |
sandbox-bundled-functional-tests: | ||
runs-on: ubuntu-latest | ||
env: | ||
FLYTESNACKS_PRIORITIES: 'P0' | ||
FLYTESNACKS_VERSION: '' | ||
timeout-minutes: 20 | ||
FLYTESNACKS_PRIORITIES: "P0" | ||
FLYTESNACKS_VERSION: "" | ||
timeout-minutes: 60 | ||
needs: [build-and-push-single-binary-image] | ||
steps: | ||
- name: Set latest Flytesnacks release | ||
|
@@ -164,7 +156,7 @@ jobs: | |
- name: Set up Python | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: '3.11' | ||
python-version: "3.11" | ||
- uses: unionai/[email protected] | ||
- name: Setup sandbox | ||
run: | | ||
|
@@ -193,25 +185,16 @@ jobs: | |
# ref: ${{ env.FLYTESNACKS_VERSION }} | ||
- name: Register specific tests | ||
run: | | ||
for f in \ | ||
basics/basics/hello_world.py \ | ||
basics/basics/workflow.py \ | ||
basics/basics/named_outputs.py \ | ||
advanced_composition/advanced_composition/chain_entities.py \ | ||
advanced_composition/advanced_composition/dynamics.py \ | ||
advanced_composition/advanced_composition/map_task.py \ | ||
advanced_composition/advanced_composition/subworkflows.py \ | ||
data_types_and_io/data_types_and_io/dataclass.py \ | ||
data_types_and_io/data_types_and_io/structured_dataset.py ; | ||
while read -r line; | ||
do | ||
pyflyte --config ./boilerplate/flyte/end2end/functional-test-config.yaml \ | ||
register \ | ||
--project flytesnacks \ | ||
--domain development \ | ||
--image cr.flyte.org/flyteorg/flytekit:py3.11-latest \ | ||
--version ${{ env.FLYTESNACKS_VERSION }} \ | ||
flytesnacks/examples/$f; | ||
done | ||
flytesnacks/$line; | ||
done < flytesnacks/flyte_tests.txt | ||
- name: End2End | ||
run: | | ||
make end2end_execute | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.