-
Notifications
You must be signed in to change notification settings - Fork 671
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove lint-all make target and simplify lint target
Signed-off-by: Eduardo Apolinario <[email protected]>
- Loading branch information
1 parent
b38b20e
commit 9ac145c
Showing
2 changed files
with
3 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -121,20 +121,6 @@ go-tidy: | |
$(MAKE) -C flytecopilot go-tidy | ||
|
||
.PHONY: lint | ||
lint-all: | ||
$(MAKE) -C datacatalog lint | ||
$(MAKE) -C flyteadmin lint | ||
$(MAKE) -C flyteidl lint | ||
$(MAKE) -C flytepropeller lint | ||
$(MAKE) -C flyteplugins lint | ||
$(MAKE) -C flytestdlib lint | ||
$(MAKE) -C flytecopilot lint | ||
|
||
|
||
.PHONY: download_tooling | ||
download_tooling: #download dependencies (including test deps) for the package | ||
@boilerplate/flyte/golang_test_targets/download_tooling.sh | ||
|
||
.PHONY: lint | ||
lint: download_tooling #lints the package for common code smells | ||
lint: #lints the package for common code smells | ||
go install github.com/golangci/golangci-lint/cmd/[email protected] | ||
GL_DEBUG=linters_output,env find . -type f -name go.mod -maxdepth 3 -execdir golangci-lint run --deadline=5m --exclude deprecated -v \; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters