Skip to content

Commit

Permalink
Remove lint-all make target and simplify lint target
Browse files Browse the repository at this point in the history
Signed-off-by: Eduardo Apolinario <[email protected]>
  • Loading branch information
eapolinario committed Dec 27, 2023
1 parent b38b20e commit 9ac145c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 21 deletions.
18 changes: 2 additions & 16 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -121,20 +121,6 @@ go-tidy:
$(MAKE) -C flytecopilot go-tidy

.PHONY: lint
lint-all:
$(MAKE) -C datacatalog lint
$(MAKE) -C flyteadmin lint
$(MAKE) -C flyteidl lint
$(MAKE) -C flytepropeller lint
$(MAKE) -C flyteplugins lint
$(MAKE) -C flytestdlib lint
$(MAKE) -C flytecopilot lint


.PHONY: download_tooling
download_tooling: #download dependencies (including test deps) for the package
@boilerplate/flyte/golang_test_targets/download_tooling.sh

.PHONY: lint
lint: download_tooling #lints the package for common code smells
lint: #lints the package for common code smells
go install github.com/golangci/golangci-lint/cmd/[email protected]
GL_DEBUG=linters_output,env find . -type f -name go.mod -maxdepth 3 -execdir golangci-lint run --deadline=5m --exclude deprecated -v \;
6 changes: 1 addition & 5 deletions boilerplate/flyte/golang_test_targets/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ download_tooling: #download dependencies (including test deps) for the package
generate: download_tooling #generate go code
@boilerplate/flyte/golang_test_targets/go-gen.sh

.PHONY: lint
lint: download_tooling #lints the package for common code smells
GL_DEBUG=linters_output,env golangci-lint run --deadline=5m --exclude deprecated -v

# If code is failing goimports linter, this will fix.
# skips 'vendor'
.PHONY: goimports
Expand Down Expand Up @@ -50,7 +46,7 @@ test_unit_cover:
test_unit_visual:
go test ./... -coverprofile /tmp/cover.out -covermode=count
go tool cover -html=/tmp/cover.out

.PHONY: test_unit_codecov
test_unit_codecov:
go test ./... -race -coverprofile=coverage.txt -covermode=atomic
Expand Down

0 comments on commit 9ac145c

Please sign in to comment.