Skip to content

Commit

Permalink
Update configmap and helper to support azure storage (#4328)
Browse files Browse the repository at this point in the history
  • Loading branch information
cgrass authored Nov 21, 2023
1 parent 61bcac3 commit aff9750
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 0 deletions.
4 changes: 4 additions & 0 deletions charts/flyte-binary/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ Chart for basic single Flyte executable deployment
| configuration.logging.plugins.stackdriver.templateUri | string | `""` | |
| configuration.storage.metadataContainer | string | `"my-organization-flyte-container"` | |
| configuration.storage.provider | string | `"s3"` | |
| configuration.storage.providerConfig.azure.account | string | `"storage-account-name"` | |
| configuration.storage.providerConfig.azure.configDomainSuffix | string | `""` | |
| configuration.storage.providerConfig.azure.configUploadConcurrency | int | `4` | |
| configuration.storage.providerConfig.azure.key | string | `""` | |
| configuration.storage.providerConfig.gcs.project | string | `"my-organization-gcp-project"` | |
| configuration.storage.providerConfig.s3.accessKey | string | `""` | |
| configuration.storage.providerConfig.s3.authType | string | `"iam"` | |
Expand Down
2 changes: 2 additions & 0 deletions charts/flyte-binary/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ Get the Flyte user data prefix.
{{- printf "s3://%s/data" $userDataContainer -}}
{{- else if eq "gcs" .Values.configuration.storage.provider -}}
{{- printf "gs://%s/data" $userDataContainer -}}
{{- else if eq "azure" .Values.configuration.storage.provider -}}
{{- printf "abfs://%s/data" $userDataContainer -}}
{{- end -}}
{{- end -}}

Expand Down
15 changes: 15 additions & 0 deletions charts/flyte-binary/templates/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,21 @@ data:
{{- printf "Invalid value for S3 storage provider authentication type. Expected one of (iam, accesskey), but got: %s" .authType | fail }}
{{- end }}
{{- end }}
{{- else if eq "azure" .provider }}
{{- with .providerConfig.azure }}
kind: azure
config:
account: {{ .account }}
{{- if .key }}
key: {{ .key }}
{{- end }}
{{- if .configDomainSuffix }}
configDomainSuffix: {{ .configDomainSuffix }}
{{- end }}
{{- if .configUploadConcurrency }}
configUploadConcurrency: {{ .configUploadConcurrency }}
{{- end }}
{{- end }}
{{- else if eq "gcs" .provider }}
kind: google
config:
Expand Down
10 changes: 10 additions & 0 deletions charts/flyte-binary/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,16 @@ configuration:
gcs:
# project Google Cloud project in which bucket resides
project: "my-organization-gcp-project"
# azure Provider configuration for Azure object store
azure:
# configDomainSuffix Domain name suffix
configDomainSuffix: ""
# configUploadConcurrency Upload Concurrency (default 4)
configUploadConcurrency: 4
# account Storage Account name
account: "storage-account-name"
# key Storage Account key if used
key: ""
# logging Specify configuration for logs emitted by Flyte
logging:
# level Set the log level
Expand Down

0 comments on commit aff9750

Please sign in to comment.