Skip to content

Commit

Permalink
lint fixes
Browse files Browse the repository at this point in the history
Signed-off-by: Jason Parraga <[email protected]>
  • Loading branch information
Sovietaced committed Jun 14, 2024
1 parent 37b8412 commit c55efe9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion flytestdlib/otelutils/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const (
FileExporter ExporterType = "file"
JaegerExporter ExporterType = "jaeger"
OtlpGrpcExporter ExporterType = "otlpGrpc"
OtlpHttpExporter ExporterType = "otlpHttp"
OtlpHTTPExporter ExporterType = "otlpHttp"
)

var (
Expand Down
8 changes: 4 additions & 4 deletions flytestdlib/otelutils/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@ package otelutils
import (
"context"
"fmt"
"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc"
"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp"
"go.opentelemetry.io/otel/trace/noop"
"os"

"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/exporters/jaeger"
"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc"
"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp"
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace"
"go.opentelemetry.io/otel/sdk/resource"
"go.opentelemetry.io/otel/sdk/trace"
semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
rawtrace "go.opentelemetry.io/otel/trace"
"go.opentelemetry.io/otel/trace/noop"

"github.com/flyteorg/flyte/flytestdlib/contextutils"
"github.com/flyteorg/flyte/flytestdlib/version"
Expand Down Expand Up @@ -80,7 +80,7 @@ func RegisterTracerProvider(ctx context.Context, serviceName string, config *Con
return err

Check warning on line 80 in flytestdlib/otelutils/factory.go

View check run for this annotation

Codecov / codecov/patch

flytestdlib/otelutils/factory.go#L78-L80

Added lines #L78 - L80 were not covered by tests
}
opts = append(opts, trace.WithBatcher(exporter))
case OtlpHttpExporter:
case OtlpHTTPExporter:

Check warning on line 83 in flytestdlib/otelutils/factory.go

View check run for this annotation

Codecov / codecov/patch

flytestdlib/otelutils/factory.go#L82-L83

Added lines #L82 - L83 were not covered by tests
// Pull configuration from environment variables
// https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/
exporter, err := otlptracehttp.New(ctx)
Expand Down

0 comments on commit c55efe9

Please sign in to comment.