Skip to content

Commit

Permalink
Update rfc/system/5606-json-idl.md
Browse files Browse the repository at this point in the history
Co-authored-by: Fabio M. Graetz, Ph.D. <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
  • Loading branch information
Future-Outlier and fg91 authored Jul 31, 2024
1 parent 957f543 commit c7f61e5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rfc/system/5606-json-idl.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Use json byte string in protobuf instead of json string to fix int is not suppor

## 2 Motivation

In Flytekit, when handling dataclasses, Pydantic base models, and dictionaries, we store data using JSON strings within struct protobuf. This approach causes issues with integers, as protobuf does not support int types, leading to their conversion to floats. This results in performance issues since we need to recursively iterate through all attributes/keys in dataclasses and dictionaries to ensure floats types are converted to int.
In Flytekit, when handling dataclasses, Pydantic base models, and dictionaries, we store data using JSON strings within struct protobuf. This approach causes issues with integers, as protobuf does not support int types, leading to their conversion to floats. This results in performance issues since we need to recursively iterate through all attributes/keys in dataclasses and dictionaries to ensure floats types are converted to int. In addition to performance issues, the required code is complicated and error prone.

Note: We have more than 10 issues about dict, dataclass and Pydantic.

Expand Down

0 comments on commit c7f61e5

Please sign in to comment.