use InvalidLiteralTypeErr instead of NewIDLTypeNotFoundErr

Signed-off-by: Future-Outlier <[email protected]>
flyteorg · Sep 25, 2024 · c8429fa · c8429fa
1 parent 5d2e062
commit c8429fa
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/flytepropeller/pkg/compiler/errors/compiler_error_test.go b/flytepropeller/pkg/compiler/errors/compiler_error_test.go
@@ -33,7 +33,7 @@ func TestErrorCodes(t *testing.T) {
 		UnrecognizedValue:          NewUnrecognizedValueErr("", ""),
 		WorkflowBuildError:         NewWorkflowBuildError(errors.New("")),
 		NoNodesFound:               NewNoNodesFoundErr(""),
-		IDLTypeNotFoundError:       NewIDLTypeNotFoundErr("", ""),
+		InvalidLiteralTypeError:    NewInvalidLiteralTypeErr("", ""),
 	}
 
 	for key, value := range testCases {

diff --git a/flytepropeller/pkg/compiler/errors/compiler_errors.go b/flytepropeller/pkg/compiler/errors/compiler_errors.go
@@ -98,7 +98,7 @@ const (
 	FieldNotFoundError ErrorCode = "FieldNotFound"
 
 	// IDL not found when variable binding
-	IDLTypeNotFoundError ErrorCode = "IDLTypeNotFound"
+	InvalidLiteralTypeError ErrorCode = "InvalidLiteralType"
 )
 
 func NewBranchNodeNotSpecified(branchNodeID string) *CompileError {
@@ -221,9 +221,9 @@ func NewMismatchingVariablesErr(nodeID, fromVar, fromType, toVar, toType string)
 	)
 }
 
-func NewIDLTypeNotFoundErr(nodeID, errMsg string) *CompileError {
+func NewInvalidLiteralTypeErr(nodeID, errMsg string) *CompileError {
 	return newError(
-		IDLTypeNotFoundError,
+		InvalidLiteralTypeError,
 		errMsg,
 		nodeID,
 	)

diff --git a/flytepropeller/pkg/compiler/transformers/k8s/inputs.go b/flytepropeller/pkg/compiler/transformers/k8s/inputs.go
@@ -48,7 +48,7 @@ func validateInputs(nodeID common.NodeID, iface *core.TypedInterface, inputs cor
 		err := validators.ValidateLiteralType(inputType)
 		if err != nil {
 			errMsg := fmt.Sprintf("Failed to validate literal type for [%s] with err: %s", inputVar, err)
-			errs.Collect(errors.NewIDLTypeNotFoundErr(nodeID, errMsg))
+			errs.Collect(errors.NewInvalidLiteralTypeErr(nodeID, errMsg))
 			continue
 		}
 

diff --git a/flytepropeller/pkg/compiler/transformers/k8s/inputs_test.go b/flytepropeller/pkg/compiler/transformers/k8s/inputs_test.go
@@ -10,7 +10,7 @@ import (
 	"github.com/flyteorg/flyte/flytepropeller/pkg/compiler/errors"
 )
 
-func TestValidateInputs_IDLTypeNotFound(t *testing.T) {
+func TestValidateInputs_InvalidLiteralType(t *testing.T) {
 	nodeID := common.NodeID("test-node")
 
 	iface := &core.TypedInterface{
@@ -42,13 +42,13 @@ func TestValidateInputs_IDLTypeNotFound(t *testing.T) {
 	idlNotFound := false
 	var errMsg string
 	for _, err := range errs.Errors().List() {
-		if err.Code() == "IDLTypeNotFound" {
+		if err.Code() == "InvalidLiteralType" {
 			idlNotFound = true
 			errMsg = err.Error()
 			break
 		}
 	}
-	assert.True(t, idlNotFound, "Expected IDLTypeNotFound error was not found in errors")
+	assert.True(t, idlNotFound, "Expected InvalidLiteralType error was not found in errors")
 
 	expectedContainedErrorMsg := "Failed to validate literal type"
 	assert.Contains(t, errMsg, expectedContainedErrorMsg)