Fix: Handle overriding of container image in backend (#4858)

* Add container image to TaskNodeOverrides proto Signed-off-by: Fabio Graetz <[email protected]> * Add container image override to v1alpha1.NodeSpec Signed-off-by: Fabio Graetz <[email protected]> * Override container image in pod Signed-off-by: Fabio Graetz <[email protected]> * Add unit test for creation of task node with image override Signed-off-by: Fabio Graetz <[email protected]> * Add unit test for building a pod with container image override Signed-off-by: Fabio Graetz <[email protected]> * Re-generate flytidl Signed-off-by: Fabio Graetz <[email protected]> * Mock GetContainerImage for ExecutableNode Signed-off-by: Fabio Graetz <[email protected]> * Make dask tests pass Signed-off-by: Fabio Graetz <[email protected]> * Lint Signed-off-by: Fabio Graetz <[email protected]> * Make kubeflow tests pass Signed-off-by: Fabio Graetz <[email protected]> * Make spark tests pass Signed-off-by: Fabio Graetz <[email protected]> * Make ray tests pass Signed-off-by: Fabio Graetz <[email protected]> * Fix remaining flyteplugins tests Signed-off-by: Fabio Graetz <[email protected]> * Add container test for image overriding Signed-off-by: Fabio Graetz <[email protected]> * Add container image override test for pytorch jobs Signed-off-by: Fabio Graetz <[email protected]> * Add ray test for container image overriding Signed-off-by: Fabio Graetz <[email protected]> * Re-generate flyteidl Signed-off-by: Fabio Graetz <[email protected]> * Add comment about container_image to TaskNodOverride proto Signed-off-by: Fabio Graetz <[email protected]> * Re-generate flyteidl Signed-off-by: Fabio Graetz <[email protected]> * Re-generate propeller Signed-off-by: Fabio Graetz <[email protected]> * Lint Signed-off-by: Fabio Graetz <[email protected]> * Re-generate flyteidl Signed-off-by: Fabio Graetz <[email protected]> --------- Signed-off-by: Fabio Graetz <[email protected]>
flyteorg · Feb 21, 2024 · e39acc7 · e39acc7
1 parent e58e3d3
commit e39acc7
Show file tree

Hide file tree

Showing 30 changed files with 449 additions and 82 deletions.
diff --git a/flyteidl/clients/go/assets/admin.swagger.json b/flyteidl/clients/go/assets/admin.swagger.json
@@ -8080,6 +8080,10 @@
         "extended_resources": {
           "$ref": "#/definitions/coreExtendedResources",
           "description": "Overrides for all non-standard resources, not captured by\nv1.ResourceRequirements, to allocate to a task."
+        },
+        "container_image": {
+          "type": "string",
+          "description": "Override for the image used by task pods."
         }
       },
       "description": "Optional task node overrides that will be applied at task execution time."

diff --git a/flyteidl/gen/pb-es/flyteidl/core/workflow_pb.ts b/flyteidl/gen/pb-es/flyteidl/core/workflow_pb.ts
diff --git a/flyteidl/gen/pb-go/flyteidl/core/workflow.pb.go b/flyteidl/gen/pb-go/flyteidl/core/workflow.pb.go
diff --git a/flyteidl/gen/pb-go/gateway/flyteidl/service/admin.swagger.json b/flyteidl/gen/pb-go/gateway/flyteidl/service/admin.swagger.json
diff --git a/flyteidl/gen/pb-js/flyteidl.d.ts b/flyteidl/gen/pb-js/flyteidl.d.ts
diff --git a/flyteidl/gen/pb-js/flyteidl.js b/flyteidl/gen/pb-js/flyteidl.js