Skip to content

Commit

Permalink
update after rebase2
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris Grass committed Dec 13, 2024
1 parent bc24fb8 commit e93b251
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions flyteadmin/pkg/data/implementations/azure_remote_url.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type AzureRemoteURL struct {
func (n *AzureRemoteURL) Get(ctx context.Context, uri string) (*admin.UrlBlob, error) {
metadata, err := n.remoteDataStoreClient.Head(ctx, storage.DataReference(uri))
if err != nil {
return admin.UrlBlob{}, errors.NewFlyteAdminErrorf(codes.Internal,
return *admin.UrlBlob{}, errors.NewFlyteAdminErrorf(codes.Internal,

Check failure on line 22 in flyteadmin/pkg/data/implementations/azure_remote_url.go

View workflow job for this annotation

GitHub Actions / compile

invalid operation: cannot indirect admin.UrlBlob{} (value of type admin.UrlBlob)
"failed to get metadata for uri: %s with err: %v", uri, err)
}

Expand All @@ -28,11 +28,11 @@ func (n *AzureRemoteURL) Get(ctx context.Context, uri string) (*admin.UrlBlob, e
ExpiresIn: n.presignDuration,
})
if err != nil {
return admin.UrlBlob{}, errors.NewFlyteAdminErrorf(codes.Internal,
return *admin.UrlBlob{}, errors.NewFlyteAdminErrorf(codes.Internal,

Check failure on line 31 in flyteadmin/pkg/data/implementations/azure_remote_url.go

View workflow job for this annotation

GitHub Actions / compile

invalid operation: cannot indirect admin.UrlBlob{} (value of type admin.UrlBlob)
"failed to get metadata for uri: %s with err: %v", uri, err)
}

return admin.UrlBlob{
return *admin.UrlBlob{

Check failure on line 35 in flyteadmin/pkg/data/implementations/azure_remote_url.go

View workflow job for this annotation

GitHub Actions / compile

invalid operation: cannot indirect admin.UrlBlob{…} (value of type admin.UrlBlob)
Url: signedUri.URL.String(),
Bytes: metadata.Size(),
}, nil
Expand Down

0 comments on commit e93b251

Please sign in to comment.