Remove PKCE scopes

Signed-off-by: Austin Liu <[email protected]>
flyteorg · Oct 20, 2024 · eb7b696 · eb7b696
1 parent 0831751
commit eb7b696
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 18 deletions.
diff --git a/flyteidl/src/auth.rs b/flyteidl/src/auth.rs
@@ -326,8 +326,10 @@ pub mod auth {
                 .oauth_client
                 .authorize_url(CsrfToken::new_random)
                 // Set the desired scopes.
-                .add_scope(Scope::new("all".to_string()))
-                .add_scope(Scope::new("offline".to_string()))
+                // .add_scope(Scope::new("offline_access".to_string()))
+                // .add_scope(Scope::new("offline".to_string()))
+                // .add_scope(Scope::new("all".to_string()))
+                // .add_scope(Scope::new("openid".to_string()))
                 // Set the PKCE code challenge.
                 .set_pkce_challenge(pkce_challenge)
                 .url();

diff --git a/flyteidl/src/lib.rs b/flyteidl/src/lib.rs
@@ -977,22 +977,22 @@ pub mod _flyteidl_rust {
             let mut access_token: String = "".to_string();
             if !insecure {
                 let cert: Certificate = auth::auth::bootstrap_creds_from_server(&endpoint_uri);
-                let tls: ClientTlsConfig = ClientTlsConfig::new()
-                    .ca_certificate(cert)
-                    .domain_name((*endpoint).to_string());
-
-                let channel = match rt.block_on(
-                    Channel::builder(endpoint_uri.clone())
-                        .tls_config(tls)
-                        .unwrap()
-                        .connect(),
-                ) {
-                    Ok(ch) => ch,
-                    Err(error) => panic!(
-                        "Failed at connecting to endpoint when constructing secured channel: {:?}",
-                        error
-                    ),
-                };
+                // let tls: ClientTlsConfig = ClientTlsConfig::new()
+                //     .ca_certificate(cert)
+                //     .domain_name((*endpoint).to_string());
+
+                // let channel = match rt.block_on(
+                //     Channel::builder(endpoint_uri.clone())
+                //         .tls_config(tls)
+                //         .unwrap()
+                //         .connect(),
+                // ) {
+                //     Ok(ch) => ch,
+                //     Err(error) => panic!(
+                //         "Failed at connecting to endpoint when constructing secured channel: {:?}",
+                //         error
+                //     ),
+                // };
 
                 let mut oauth_client: auth::auth::OAuthClient = auth::auth::OAuthClient::new(
                     endpoint,