-
Notifications
You must be signed in to change notification settings - Fork 671
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve literal type string representation handling
Signed-off-by: Kevin Su <[email protected]>
- Loading branch information
Showing
8 changed files
with
58 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package utils | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/core" | ||
| "strings" | ||
| ) | ||
|
|
||
| func LiteralTypeToStr(lt *core.LiteralType) string { | ||
| if lt == nil { | ||
| return "None" | ||
| } | ||
| if lt.GetSimple() == core.SimpleType_STRUCT { | ||
| var structure string | ||
| for k, v := range lt.GetStructure().GetDataclassType() { | ||
| structure += fmt.Sprintf("dataclass_type:{key:%v value:{%v}, ", k, LiteralTypeToStr(v)) | ||
| } | ||
| structure = strings.TrimSuffix(structure, ", ") | ||
| return fmt.Sprintf("Simple: STRUCT structure{%v}", structure) | ||
| } | ||
| return lt.String() | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| package utils | ||
|
|
||
| import ( | ||
| "github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/core" | ||
| "github.com/stretchr/testify/assert" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestLiteralTypeToStr(t *testing.T) { | ||
| assert.Equal(t, LiteralTypeToStr(nil), "None") | ||
| assert.Equal(t, LiteralTypeToStr(&core.LiteralType{ | ||
| Type: &core.LiteralType_Simple{Simple: core.SimpleType_STRUCT}, | ||
| Structure: &core.TypeStructure{ | ||
| DataclassType: map[string]*core.LiteralType{ | ||
| "a": { | ||
| Type: &core.LiteralType_Simple{Simple: core.SimpleType_INTEGER}, | ||
| }, | ||
| }, | ||
| }, | ||
| }), "Simple: STRUCT structure{dataclass_type:{key:a value:{simple:INTEGER}}") | ||
| } |