fix tests

Signed-off-by: Kevin Su <[email protected]>
flyteorg · Nov 24, 2023 · f40f62f · f40f62f
1 parent 1b67946
commit f40f62f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/flyteplugins/go/tasks/pluginmachinery/internal/webapi/launcher_test.go b/flyteplugins/go/tasks/pluginmachinery/internal/webapi/launcher_test.go
@@ -79,8 +79,9 @@ func Test_launch(t *testing.T) {
 
 		plgn := newPluginWithProperties(webapi.PluginConfig{})
 		plgn.OnCreate(ctx, tCtx).Return("", nil, fmt.Errorf("error creating"))
-		_, _, err := launch(ctx, plgn, tCtx, c, &s)
-		assert.Error(t, err)
+		_, phase, err := launch(ctx, plgn, tCtx, c, &s)
+		assert.Nil(t, err)
+		assert.Equal(t, core.PhasePermanentFailure, phase.Phase())
 	})
 
 	t.Run("Failed to cache", func(t *testing.T) {