Skip to content

Commit

Permalink
Fix merge
Browse files Browse the repository at this point in the history
Signed-off-by: Mecoli1219 <[email protected]>
  • Loading branch information
Mecoli1219 committed Sep 22, 2024
1 parent b6ab49b commit fa27e1a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions flyteidl/clients/go/coreutils/literals.go
Original file line number Diff line number Diff line change
Expand Up @@ -466,8 +466,8 @@ func MakeLiteralTuple(name string, order []string, v map[string]interface{}) (*c

return &core.LiteralTupleMap{
TupleName: name,
Order: order,
Literals: literals,
Order: order,
Literals: literals,
}, nil

}
Expand Down
2 changes: 1 addition & 1 deletion flytepropeller/pkg/compiler/validators/bindings.go
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ func validateBinding(w c.WorkflowBuilder, node c.Node, nodeParam string, binding
if expectedField, ok := expectedType.GetTupleType().GetFields()[k]; !ok {
errs.Collect(errors.NewFieldNotFoundErr(nodeID, nodeParam, expectedType.String(), k))

Check warning on line 246 in flytepropeller/pkg/compiler/validators/bindings.go

View check run for this annotation

Codecov / codecov/patch

flytepropeller/pkg/compiler/validators/bindings.go#L246

Added line #L246 was not covered by tests
} else {
if fieldType, nodeIds, ok := validateBinding(w, nodeID, nodeParam, v, expectedField, errs.NewScope(), validateParamTypes); ok {
if fieldType, nodeIds, ok := validateBinding(w, node, nodeParam, v, expectedField, errs.NewScope(), validateParamTypes); ok {
allNodeIds = append(allNodeIds, nodeIds...)
fields[k] = fieldType
}
Expand Down

0 comments on commit fa27e1a

Please sign in to comment.