Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlyteCTL Feature] add a --output flag for pyflyte register #3919

Open
2 tasks done
Tracked by #4064
zeryx opened this issue Aug 2, 2023 · 9 comments
Open
2 tasks done
Tracked by #4064

[FlyteCTL Feature] add a --output flag for pyflyte register #3919

zeryx opened this issue Aug 2, 2023 · 9 comments
Labels
enhancement New feature or request fit-and-finish flytekit FlyteKit Python related issue good first issue Good for newcomers stale

Comments

@zeryx
Copy link

zeryx commented Aug 2, 2023

Describe the feature/command for FlyteCTL

pyflyte register today does not have any mechanism for providing an organized output containing the registered workflow/task/launchplan names, and their versions.

This request would be to provide a --output=X flag that can denote how the output should be formatted.
This could be by default =json, and =yaml.

Provide a possible output or UX example

I should be able to run pyflyte register --remote somewf_dir --output=json
and the following output.json file should exist in the repo

[{"type":"workflow", "name":"somewf_dir.workflow_file.wf", "version":"abcd123"}, {"type":"task", "name":"somewf_dir.workflow_file.task_a", "version":"abcd123"}]

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@zeryx zeryx added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Aug 2, 2023
@eapolinario eapolinario added good first issue Good for newcomers flytekit FlyteKit Python related issue fit-and-finish and removed untriaged This issues has not yet been looked at by the Maintainers labels Aug 4, 2023
@Future-Outlier
Copy link
Member

Hi, I am interested in this issue, please give me a chance.

@TechWizard9999
Copy link

😊 "I'd be delighted to work on this issue, @zeryx ! Could you please assign it to me?"

@Kota-Karthik
Copy link

@samhita-alla @zeryx
I am interested in doing this issue
So kindly assign me this issue
Thank You : )

@samhita-alla
Copy link
Contributor

Please go ahead and create a PR, @TechWizard9999, @Kota-Karthik. We will consider whoever creates a PR first on a first-come, first-serve basis.

@SoumyoPurkayastha
Copy link

@samhita-alla I'm interested in working on this issue. If I can make the feature, can I create a PR?

@Future-Outlier
Copy link
Member

@samhita-alla I'm interested in working on this issue. If I can make the feature, can I create a PR?

She means that the first pr will be accepted!

@adarsh-jha-dev
Copy link
Contributor

@samhita-alla , I have raised a PR for this, I request you to please have a look at it and let me know if the changes are valid

Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@paullongtan
Copy link

@samhita-alla
Hi, is this issue still active?
Can you work on it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fit-and-finish flytekit FlyteKit Python related issue good first issue Good for newcomers stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants