Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #3919 : Added Output Format Option to flyte single start Command #4300

Closed
wants to merge 1 commit into from
Closed

Conversation

adarsh-jha-dev
Copy link
Contributor

Tracking issue

closes #3919

Describe your changes

In the start.go file, I introduced a new command, flyte single start, which is used to start a Flyte cluster locally. This command includes the following key changes:

  • The startCmd variable is defined to create a new Cobra command named "start." It has a brief description indicating its purpose.
  • Inside the RunE function of this command, an error group (errgroup) is created, and the childCtx context is derived from the parent context (ctx).
  • You access the configuration using the GetConfig() function to retrieve the configuration settings for different components such as Admin, Propeller, and DataCatalog.
  • Three different components are started in parallel if they are not explicitly disabled in the configuration:
  • Admin: The Flyte Admin server, including database migrations and seeding of default projects.
  • Propeller: The Flyte Propeller component, including its controller and webhook server.
  • DataCatalog: The Flyte DataCatalog component, including database migrations.
  • The errgroup (g) is used to coordinate the start of these components in parallel.
  • Finally, the function waits for all the components to complete by calling g.Wait().

This change allows users to conveniently start a Flyte cluster locally using a single command while providing the flexibility to disable specific components as needed.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

N/A

Note to reviewers

Please review this and let me know if the changes are relevant to the issue. Your feedback is greatly appreciated.

Signed-off-by: Adarsh Jha <[email protected]>
@samhita-alla
Copy link
Contributor

@adarsh-jha-dev, this PR doesn't look correct to me. It isn't even related to the issue you mentioned.

@adarsh-jha-dev
Copy link
Contributor Author

adarsh-jha-dev commented Oct 28, 2023

@samhita-alla really sorry for the inconvenience caused, i misunderstood the issue. I will raise another PR for this with valid changes , i request you, please don't unassign me.

@adarsh-jha-dev
Copy link
Contributor Author

@adarsh-jha-dev, this PR doesn't look correct to me. It isn't even related to the issue you mentioned.

@samhita-alla , could you please help me find the relevant source code for this issue, I am unable to find it.

@samhita-alla
Copy link
Contributor

Looks like a PR has already been created for the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FlyteCTL Feature] add a --output flag for pyflyte register
2 participants