Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] document the process of rendering a notebooktask in a flyte deck #4463

Closed
2 tasks done
Tracked by #5783
samhita-alla opened this issue Nov 20, 2023 · 15 comments · Fixed by flyteorg/flytesnacks#1742
Closed
2 tasks done
Tracked by #5783
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest pri3

Comments

@samhita-alla
Copy link
Contributor

Description

the papermill example in the flyte docs lacks info on rendering the notebook in a deck. to achieve this, add render_deck=True and disable_deck=False to the notebooktask.

slack thread for reference: https://discuss.flyte.org/t/15484282/hi-all-flyte-rookie-here-maybe-you-can-help-me-out-i-m-tryin#33b0b813-6822-4451-8977-eaec3387a4ff

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@samhita-alla samhita-alla added documentation Improvements or additions to documentation pri3 labels Nov 20, 2023
@samhita-alla samhita-alla changed the title [Docs] document how to render notebooktask in a flyte deck [Docs] document the process of rendering a notebooktask in a flyte deck Nov 20, 2023
@RaghavMangla
Copy link
Contributor

Hi, I would like to work on this

@davidmirror-ops
Copy link
Contributor

@RaghavMangla a change merged today changes location for most of the content in the docs. Please update your fork to prevent conflicts. Thanks!

@RaghavMangla
Copy link
Contributor

Hi! this is the link for my pull request, flyteorg/flytesnacks#1741

@RaghavMangla
Copy link
Contributor

hi, i have fixed the deprecated issue, it shd work now, link
flyteorg/flytesnacks@954fe57

@RaghavMangla
Copy link
Contributor

@RaghavMangla
Copy link
Contributor

Hi, @davidmirror-ops @samhita-alla, can u pls review my PR, it's 1742, link shared above

@RaghavMangla
Copy link
Contributor

Screenshot 2024-10-07 at 8 13 04 PM Hi! I have shared the screenshot of the notebook being rendered after running the workflow on Flyte sandbox, this is my pull request https://github.com/flyteorg/flytesnacks/pull/1742

@RaghavMangla
Copy link
Contributor

i think this pull request does exactly what's desired
flyteorg/flytekit#2791

it changes the notebooktask in papermill plugin in flyte docs, was not able to render html page due to version conflicts but have added enable_deck=True in notebook task

@RaghavMangla
Copy link
Contributor

RaghavMangla commented Oct 8, 2024

@samhita-alla pls review this pr flyteorg/flytekit#2791

@RaghavMangla
Copy link
Contributor

@samhita-alla just noticed that my PR flyteorg/flytesnacks#1742 failed with this error

Error: buildx failed with: ERROR: failed to solve: process "/bin/sh -c apt-get update && apt-get install -y software-properties-common && add-apt-repository ppa:deadsnakes/ppa && apt-get install -y && apt-get update && apt-get install -y cmake curl python3.8 python3.8-venv python3.8-dev make build-essential libssl-dev libffi-dev python3-pip zlib1g-dev vim wget" did not complete successfully: exit code: 1

can u suggest a fix

@RaghavMangla
Copy link
Contributor

Hi! @samhita-alla all tests have passed for flyteorg/flytesnacks#1742, will it be considered for hacktoberfest-accepted

@RaghavMangla
Copy link
Contributor

RaghavMangla commented Oct 10, 2024

Hi! @samhita-alla @davidmirror-ops are there any updates that I need to make?

@RaghavMangla
Copy link
Contributor

Hi! @samhita-alla @davidmirror-ops, my PR (which was relevant to this issue): flyteorg/flytekit#2791 has been merged, in the PR I added the enable_deck=True line in notebookTask in the jupyter notebook documentation of papermill plugin

@RaghavMangla
Copy link
Contributor

Could you please share any suggestions or changes that might be required? If everything looks good from your end, I believe we can go ahead and close this issue.

@RaghavMangla
Copy link
Contributor

@davidmirror-ops @samhita-alla Could you please share any suggestions or changes that might be required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest pri3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants