Pr 1741 #1742
Merged
Pr 1741 #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2024
|
Hi! I have used enable_deck=True as told, actually first I used disable_deck=False, and created pull request 1741 but then since it was deprecated, i edited it to enable_deck=True and made this change |
|
can you fix the DCO? https://github.com/flyteorg/flytesnacks/pull/1742/checks?check_run_id=31121459053 |
…te deck Signed-off-by: RaghavMangla <[email protected]>
Signed-off-by: RaghavMangla <[email protected]>
|
done
…On Tue, Oct 8, 2024 at 2:56 PM Samhita Alla ***@***.***> wrote:
can you fix the DCO?
https://github.com/flyteorg/flytesnacks/pull/1742/checks?check_run_id=31121459053
—
Reply to this email directly, view it on GitHub
<#1742 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXGSZMKIELT5NT3PVEPYDPDZ2OQNDAVCNFSM6AAAAABPNPFL32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGMZTCNRXGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
btw can u also review this pr, @ <https://github.com/samhita-alla>
flyteorg/flytekit#2791 <flyteorg/flytekit#2791>, i
think its relevant to this issue
On Tue, Oct 8, 2024 at 3:53 PM Raghav Mangla ***@***.***>
wrote:
… done
On Tue, Oct 8, 2024 at 2:56 PM Samhita Alla ***@***.***>
wrote:
> can you fix the DCO?
> https://github.com/flyteorg/flytesnacks/pull/1742/checks?check_run_id=31121459053
>
> —
> Reply to this email directly, view it on GitHub
> <#1742 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AXGSZMKIELT5NT3PVEPYDPDZ2OQNDAVCNFSM6AAAAABPNPFL32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGMZTCNRXGM>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
Just noticed that the PR run failed for
#1742/, can u pls share abt how
to fix this issue
On Tue, Oct 8, 2024 at 3:56 PM Raghav Mangla ***@***.***>
wrote:
… btw can u also review this pr, @ <https://github.com/samhita-alla>
flyteorg/flytekit#2791 <flyteorg/flytekit#2791>,
i think its relevant to this issue
On Tue, Oct 8, 2024 at 3:53 PM Raghav Mangla ***@***.***>
wrote:
> done
>
> On Tue, Oct 8, 2024 at 2:56 PM Samhita Alla ***@***.***>
> wrote:
>
>> can you fix the DCO?
>> https://github.com/flyteorg/flytesnacks/pull/1742/checks?check_run_id=31121459053
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#1742 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AXGSZMKIELT5NT3PVEPYDPDZ2OQNDAVCNFSM6AAAAABPNPFL32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGMZTCNRXGM>
>> .
>> You are receiving this because you authored the thread.Message ID:
>> ***@***.***>
>>
>
|
|
@RaghavMangla I think that might have been a timeout error, so I re-ran the failed test. |
|
@samhita-alla @neverett Hi! can u pls review the PR, all checks have passed |
neverett
approved these changes
Oct 10, 2024
|
Hi! @ppiegaze pls review the PR, lmk if any changes are required |
|
are there any other changes required in the PR? |
neverett
requested review from
davidmirror-ops and
samhita-alla
and removed request for
ppiegaze
|
This looks good to me, but I went ahead and added @davidmirror-ops and @samhita-alla as reviewers, since I'm a bit confused about the two open PRs. Can we close #1741 ? |
|
yes, could you please review the PRs and share with me if any changes are
needed @davidmirror-ops <https://github.com/davidmirror-ops> @samhita-alla
<https://github.com/samhita-alla>
…On Fri, Oct 11, 2024 at 9:37 PM Nikki Everett ***@***.***> wrote:
This looks good to me, but I went ahead and added @davidmirror-ops
<https://github.com/davidmirror-ops> and @samhita-alla
<https://github.com/samhita-alla> as reviewers, since I'm a bit confused
about the two open PRs. Can we close #1741
<#1741> ?
—
Reply to this email directly, view it on GitHub
<#1742 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXGSZMI6KWXQ5YDQDBBVLS3Z27ZUXAVCNFSM6AAAAABPNPFL32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBXG4YTONRXHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
samhita-alla
approved these changes
Oct 14, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed deprecated disable_deck, enable_deck=True has been used
fixes flyteorg/flyte#4463