Update to go 1.21 #4534
Merged
Update to go 1.21 #4534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
dosubot
bot
added
the
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4534 +/- ##
==========================================
- Coverage 58.98% 58.93% -0.06%
==========================================
Files 621 620 -1
Lines 52483 52432 -51
==========================================
- Hits 30957 30900 -57
- Misses 19059 19069 +10
+ Partials 2467 2463 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <[email protected]>
dosubot
bot
added
size:M
Signed-off-by: Eduardo Apolinario <[email protected]>
|
we need to update the go version in all the github checks too right? (ex flyte/.github/workflows/checks.yml Line 13 in aff1150 |
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
hamersaw
approved these changes
Dec 11, 2023
pvditt
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Update to go 1.21 Signed-off-by: Eduardo Apolinario <[email protected]> * Update go version in dockerfiles Signed-off-by: Eduardo Apolinario <[email protected]> * Use alpine 3.18 in component images Signed-off-by: Eduardo Apolinario <[email protected]> * Update other references to go 1.19 Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Paul Dittamo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link