Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Clear instructions for exposing prometheus metrics for flyte-binary #5205

Closed
2 tasks done
cjidboon94 opened this issue Apr 9, 2024 · 2 comments
Closed
2 tasks done
Assignees
Labels
backlogged For internal use. Reserved for contributor team workflow. documentation Improvements or additions to documentation

Comments

@cjidboon94
Copy link
Contributor

Description

Currently it's unclear how to setup flyte-binary so that it exposes prometheus metrics.
It seems that it is possible as is suggested by #3758 , however that issues also describe that even if one sets up the metrics they might not be able to get all the metrics that flyte provides.
For flyte-core this seems straightforward and there are clear fields in the values file for the helm chart.
Would be great to have something similar in the flyte-binary chart (and documentation if not possible)

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@cjidboon94 cjidboon94 added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers labels Apr 9, 2024
@brndnblck brndnblck added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Apr 10, 2024
@wild-endeavor wild-endeavor self-assigned this Apr 11, 2024
@wild-endeavor wild-endeavor added backlogged For internal use. Reserved for contributor team workflow. and removed untriaged This issues has not yet been looked at by the Maintainers labels Apr 11, 2024
@brndnblck brndnblck added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Apr 11, 2024
@wild-endeavor
Copy link
Contributor

wild-endeavor commented Apr 16, 2024

@cjidboon94 i'm not sure if the issue you linked is still an issue, but you should be able to see prometheus metrics out of the box in the flyte-binary deployment. At least testing using the flytectl demo environment, if I just port-forward the flyte pod, port 10254, I'm able to see it on http://localhost:10254/metrics. flytectl doesn't port forward that port out of the box but once you do you should be able to see it. Is it not working for you? Can you confirm nothing's being served on that port in your case?

@cjidboon94
Copy link
Contributor Author

@wild-endeavor Cheers! That was the missing link. I was expecting it to be on http://localhost:10254/. Adding metrics to the end of the path, works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlogged For internal use. Reserved for contributor team workflow. documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants