Update Monitoring documentation #5206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: davidmirror-ops <[email protected]>
davidmirror-ops
changed the title
Signed-off-by: davidmirror-ops <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5206 +/- ##
==========================================
+ Coverage 58.99% 59.92% +0.93%
==========================================
Files 645 81 -564
Lines 55542 5101 -50441
==========================================
- Hits 32769 3057 -29712
+ Misses 20182 1851 -18331
+ Partials 2591 193 -2398
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: davidmirror-ops <[email protected]>
davidmirror-ops
changed the title
dosubot
bot
added
size:M
neverett
previously approved these changes
Apr 9, 2024
|
|
||
| .. note:: | ||
|
|
||
| The above mentioned are basic dashboards and do no include all the metrics exposed by Flyte. |
There was a problem hiding this comment.
Suggested change
| The above mentioned are basic dashboards and do no include all the metrics exposed by Flyte. | |
| The dashboards mentioned are basic dashboards and do not include all the metrics exposed by Flyte. |
| The above mentioned are basic dashboards and do no include all the metrics exposed by Flyte. | ||
| Feel free to use the scripts provided `here <https://github.com/flyteorg/flyte/tree/master/stats>`__ to improve and -hopefully- contribute the improved dashboards. | ||
|
|
||
| To consume the dashboards, it's recommended to install and configure the Prometheus operator as described in `their docs <https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/user-guides/getting-started.md>`__. |
There was a problem hiding this comment.
Suggested change
| To consume the dashboards, it's recommended to install and configure the Prometheus operator as described in `their docs <https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/user-guides/getting-started.md>`__. | |
| To consume the dashboards, we recommend installing and configuring the Prometheus operator as described in `their docs <https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/user-guides/getting-started.md>`__. |
Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: davidmirror-ops <[email protected]>
|
@neverett I fixed some errors and proposed a slightly better format for the instructions. Thank you! |
neverett
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Similar to what's requested on #5205 and while this PR doesn't close that Issue, it adds recommendations on how to make use of the Grafana dashboards, connecting a Prometheus instance, the Service Monitors and the necessary Grafana config.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link