Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo build images #4027

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
d731579
Add dockerfiles
eapolinario Sep 12, 2023
9a5c5f9
Build component using reusable workflow
eapolinario Sep 12, 2023
84ffbae
Add "Components checks" workflow
eapolinario Sep 12, 2023
1d147c7
Fix typo
eapolinario Sep 12, 2023
68d4b18
Rename gh workflow
eapolinario Sep 12, 2023
e9758ab
Use the correct dockerfile
eapolinario Sep 12, 2023
48b70e2
Enable endtoend tests
eapolinario Sep 12, 2023
a3555c5
Use correct path to end2end reusable workflow
eapolinario Sep 12, 2023
9537a36
Use unique prefixes for the cache
eapolinario Sep 13, 2023
4905209
Use tmp/tmp
eapolinario Sep 13, 2023
af0ba31
Be more explicit about the path components docker images are saved to
eapolinario Sep 13, 2023
82919cd
Test only overriding datacatalog image
eapolinario Sep 13, 2023
55dc39e
Comment out actual helm upgrades (i.e. simply run tests)
eapolinario Sep 13, 2023
fcab4e5
Comment out end2end and bring integration tests
eapolinario Sep 13, 2023
2cc98b7
Fix typo in definition of priorities
eapolinario Sep 13, 2023
07dfe12
Hardcode go version to 1.19
eapolinario Sep 13, 2023
13a0dac
Use correct working directory in integration.yml
eapolinario Sep 13, 2023
a0e95cd
Enable flytepropeller integration tests
eapolinario Sep 13, 2023
531ee51
Unpack envvars prior to calling reusable workflow
eapolinario Sep 13, 2023
3b741ba
Enable go_generate.yml
eapolinario Sep 13, 2023
9a3c3ec
Enable push_docker_image
eapolinario Sep 13, 2023
308a12c
Fix flytecopilot go generate
eapolinario Sep 13, 2023
67ba70b
Fix image tags
eapolinario Sep 13, 2023
272321a
Enable lint and unit tests
eapolinario Sep 13, 2023
944ee23
Pass component to lint and unit-tests jobs
eapolinario Sep 13, 2023
135c4aa
Fix flytestdlib unit test
eapolinario Sep 13, 2023
9553c6a
Fix flyteplugins test
eapolinario Sep 13, 2023
3e4101d
Build flytescheduler image
eapolinario Sep 13, 2023
c6ac977
Monorepo ci checks fix lint (#4032)
eapolinario Sep 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix flyteplugins test
Signed-off-by: Eduardo Apolinario <[email protected]>
  • Loading branch information
eapolinario committed Sep 13, 2023
commit 9553c6a2f9f073f580d730d9ebec0d0150f7f224
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,17 @@ import (

"github.com/flyteorg/flyte/flytestdlib/storage"

"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/core"
pluginsIOMock "github.com/flyteorg/flyte/flyteplugins/go/tasks/pluginmachinery/io/mocks"
storageMocks "github.com/flyteorg/flyte/flytestdlib/storage/mocks"
"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/core"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
)

type MemoryMetadata struct {
exists bool
size int64
etag string
}

func (m MemoryMetadata) Size() int64 {
Expand All @@ -26,6 +27,10 @@ func (m MemoryMetadata) Exists() bool {
return m.exists
}

func (m MemoryMetadata) Etag() string {
return m.etag
}

func TestReadOrigin(t *testing.T) {
ctx := context.TODO()

Expand Down
7 changes: 6 additions & 1 deletion flyteplugins/go/tasks/plugins/array/k8s/management_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import (
type metadata struct {
exists bool
size int64
etag string
}

func (m metadata) Exists() bool {
Expand All @@ -44,6 +45,10 @@ func (m metadata) Size() int64 {
return m.size
}

func (m metadata) Etag() string {
return m.etag
}

func createSampleContainerTask() *core2.Container {
return &core2.Container{
Command: []string{"cmd"},
Expand Down Expand Up @@ -124,7 +129,7 @@ func getMockTaskExecutionContext(ctx context.Context, parallelism int) *mocks.Ta
matchedBy := mock.MatchedBy(func(s storage.DataReference) bool {
return true
})
composedProtobufStore.On("Head", mock.Anything, matchedBy).Return(metadata{true, 0}, nil)
composedProtobufStore.On("Head", mock.Anything, matchedBy).Return(metadata{true, 0, ""}, nil)
dataStore := &storage.DataStore{
ComposedProtobufStore: composedProtobufStore,
ReferenceConstructor: &storage.URLPathConstructor{},
Expand Down