add codespell: config, workflow and have typos fixed #4054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaroslav Halchenko <[email protected]>
Signed-off-by: Yaroslav Halchenko <[email protected]>
Signed-off-by: Yaroslav Halchenko <[email protected]>
Signed-off-by: Yaroslav Halchenko <[email protected]>
…of docs/) Signed-off-by: Yaroslav Halchenko <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
yarikoptic
force-pushed
the
enh-codespell
branch
from
3615c01 to
623ebca
Compare
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w || :",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
commented
Sep 20, 2023
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -i3 -C4 -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
Signed-off-by: Yaroslav Halchenko <[email protected]>
yarikoptic
force-pushed
the
enh-codespell
branch
from
623ebca to
ff32044
Compare
pingsutw
approved these changes
Sep 22, 2023
|
Congrats on merging your first pull request! 🎉 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I was listening a talk today featuring flyte, decided to check it out...
This PR introduces https://github.com/codespell-project/codespell to this repo -- codespell has a list of most common typos, and this way allows for quite robust check/fixing of the codebases so looks like "spellchecking". Here I provide config to ignore some few ad-hoc variables etc, github action which would fail if new typo is introduced, and fixing a good number of typos. Note that a few typos were fixed in the code but I do not think those fixes are 'functional', but please check.
Also there was a commit (currently e609875) which fixed up .gitignore so that actually tracked by git folder is not ignored
Check all the applicable boxes