Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monorepo] Update manifest using the monorepo components #4082

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

eapolinario
Copy link
Contributor

Describe your changes

This PR changes the generation of manifests to use the versions of components in the monorepo.

A few things to note:

  1. This process relies on the fact that changes to components trigger the creation of tags once they are merged to master. This essentially means that two consecutive releases are not supported since component tags are only generated once changes to components are merged to master. We might need to relax this constraint and assume that all merges to master produce component tags.
  2. In order to generate the config docs we no longer download component binaries from releases, instead we compile them in place.
  3. The release process described in https://github.com/flyteorg/flyte/blob/master/RELEASE.md#create-a-release stays unchanged.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8090b16) 58.95% compared to head (397cd71) 59.26%.

❗ Current head 397cd71 differs from pull request most recent head 8a97a37. Consider uploading reports for the commit 8a97a37 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4082      +/-   ##
==========================================
+ Coverage   58.95%   59.26%   +0.30%     
==========================================
  Files         618      549      -69     
  Lines       52676    39581   -13095     
==========================================
- Hits        31057    23459    -7598     
+ Misses      19140    13807    -5333     
+ Partials     2479     2315     -164     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 555 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 8c05f4e into master Sep 26, 2023
35 of 36 checks passed
@eapolinario eapolinario deleted the monorepo--release branch September 26, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants