Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ResourceWrapper without pointer #4115

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Return ResourceWrapper without pointer #4115

merged 5 commits into from
Oct 5, 2023

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Oct 2, 2023

TL;DR

Worker in async cache panics because it fails to cast resource to *ResourceWrapper

cache (*Resource) -> cast to (*Resource) // it works

s3 (Resource) -> cast to (*Resource) // Failed to do type casting since we unmarshall the resource to Resource here.

We read the resource from s3 bucket after restarting the propeller (cache becomes empty).

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Kevin Su <[email protected]>
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b35cc95) 58.98% compared to head (a3ae032) 59.31%.

❗ Current head a3ae032 differs from pull request most recent head ce94855. Consider uploading reports for the commit ce94855 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4115      +/-   ##
==========================================
+ Coverage   58.98%   59.31%   +0.33%     
==========================================
  Files         618      549      -69     
  Lines       52708    39609   -13099     
==========================================
- Hits        31088    23493    -7595     
+ Misses      19140    13800    -5340     
+ Partials     2480     2316     -164     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...yteplugins/go/tasks/plugins/webapi/agent/plugin.go 68.71% <100.00%> (+2.66%) ⬆️
...ugins/go/tasks/plugins/webapi/databricks/plugin.go 65.65% <100.00%> (+4.31%) ⬆️
...lugins/go/tasks/plugins/webapi/snowflake/plugin.go 66.25% <87.50%> (+4.95%) ⬆️

... and 552 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit 81b94a4 into master Oct 5, 2023
36 checks passed
@pingsutw pingsutw deleted the update-agent branch October 5, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants