Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from flyteplugins - Use dask cuda worker when GPU resource > 0 #4129

Closed

Conversation

eapolinario
Copy link
Contributor

TL;DR

If a gpu has been specified in the dask plugin resource, assume we want to use dask cuda worker i.e. that dask-cuda is present on the specified image.

Type

  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Currently we build an arg to submit to the container and inject values such as threads and memory from the limits specified in the resources object in the dask plugin object. Dask cuda gives us many built in gpu tools and all that is required is to ensure dask cuda is installed and then to start out workers with dask-cuda-worker. So, in order to accomodate, we simply check for gpu limits in the dask plugin resources and overwrite the first arg to dask-cuda-worker.

ljstrnadiii and others added 3 commits April 3, 2023 03:44
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d9586b0) 58.98% compared to head (6e0886e) 57.51%.

❗ Current head 6e0886e differs from pull request most recent head be83adc. Consider uploading reports for the commit be83adc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4129      +/-   ##
==========================================
- Coverage   58.98%   57.51%   -1.47%     
==========================================
  Files         619      394     -225     
  Lines       52804    28988   -23816     
==========================================
- Hits        31146    16673   -14473     
+ Misses      19174    10626    -8548     
+ Partials     2484     1689     -795     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 575 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants