Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from flyteplugins - updated maptask log links to use original index #4134

Closed

Conversation

eapolinario
Copy link
Contributor

TL;DR

Updated the maptask log links to use the subtask original index rather than the execution index.

NOTE: This change means that log links will not match the pod name in scenarios where the subtask execution and original indicies differ (ex. cache hits).

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

hamersaw and others added 2 commits August 31, 2023 10:49
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a18da03) 59.00% compared to head (7f75036) 59.33%.
Report is 2 commits behind head on master.

❗ Current head 7f75036 differs from pull request most recent head 5911a1d. Consider uploading reports for the commit 5911a1d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4134      +/-   ##
==========================================
+ Coverage   59.00%   59.33%   +0.33%     
==========================================
  Files         619      550      -69     
  Lines       52827    39711   -13116     
==========================================
- Hits        31170    23563    -7607     
+ Misses      19173    13828    -5345     
+ Partials     2484     2320     -164     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lugins/go/tasks/plugins/array/awsbatch/executor.go 43.75% <100.00%> (+1.19%) ⬆️
...yteplugins/go/tasks/plugins/array/core/metadata.go 80.00% <100.00%> (-2.23%) ⬇️
...lyteplugins/go/tasks/plugins/array/k8s/executor.go 40.67% <100.00%> (+1.09%) ⬆️
...go/tasks/plugins/array/k8s/subtask_exec_context.go 83.33% <85.71%> (+1.51%) ⬆️

... and 552 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamersaw
Copy link
Contributor

Closed as unplanned.

@hamersaw hamersaw closed this Dec 13, 2023
@hamersaw hamersaw deleted the monorepo-move/flyteplugins/bug/maptask-log-index branch December 13, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants