Moving from flyteadmin - Add UpdateTag Function #4142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Da-Yi Wu <[email protected]>
Signed-off-by: Da-Yi Wu <[email protected]>
Signed-off-by: Da-Yi Wu <[email protected]>
…ve/flyteadmin/update_tag
8 tasks
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4142 +/- ##
==========================================
+ Coverage 58.98% 59.09% +0.10%
==========================================
Files 619 368 -251
Lines 52804 25539 -27265
==========================================
- Hits 31146 15091 -16055
+ Misses 19174 9012 -10162
+ Partials 2484 1436 -1048
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ericwudayi
added a commit
to ericwudayi/flyte
that referenced
this pull request
Oct 5, 2023
ericwudayi
added a commit
to ericwudayi/flyte
that referenced
this pull request
Oct 5, 2023
Signed-off-by: Da-Yi Wu <[email protected]>
ericwudayi
added a commit
to ericwudayi/flyte
that referenced
this pull request
Oct 15, 2023
Signed-off-by: Da-Yi Wu <[email protected]> Modify UpdateExecutionModelTag Signed-off-by: Da-Yi Wu <[email protected]> Update the Tags into Execution.Tag Signed-off-by: Da-Yi Wu <[email protected]> Update Execution Tag(flyteorg#4142) Signed-off-by: Da-Yi Wu <[email protected]> Add unit test for add tags Signed-off-by: Da-Yi Wu <[email protected]> Add unit test for add tag (flyteorg#4185) Signed-off-by: Da-Yi Wu <[email protected]> Add Tags Signed-off-by: Da-Yi Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add Update tag feature into the Flyteadmin
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/