Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version control for ArrayNode eventing #4165

Merged
merged 13 commits into from
Oct 9, 2023
Merged
4 changes: 4 additions & 0 deletions flyteadmin/pkg/repositories/transformers/node_execution.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@
SpecNodeId: input.Request.Event.SpecNodeId,
IsParentNode: input.Request.Event.IsParent,
IsDynamic: input.Request.Event.IsDynamic,
IsArray: input.Request.Event.IsArray,
}
err := handleNodeExecutionInputs(ctx, nodeExecution, input.Request, input.StorageClient)
if err != nil {
Expand Down Expand Up @@ -304,6 +305,9 @@
if request.Event.IsDynamic {
nodeExecutionMetadata.IsDynamic = true
}
if request.Event.IsArray {
nodeExecutionMetadata.IsArray = true
}

Check warning on line 310 in flyteadmin/pkg/repositories/transformers/node_execution.go

View check run for this annotation

Codecov / codecov/patch

flyteadmin/pkg/repositories/transformers/node_execution.go#L309-L310

Added lines #L309 - L310 were not covered by tests
nodeExecMetadataBytes, err := proto.Marshal(&nodeExecutionMetadata)
if err != nil {
return errors.NewFlyteAdminErrorf(codes.Internal,
Expand Down
158 changes: 100 additions & 58 deletions flyteidl/gen/pb-cpp/flyteidl/admin/node_execution.pb.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions flyteidl/gen/pb-cpp/flyteidl/admin/node_execution.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading