Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gh workflow to publish flyteidl to buf #4178

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Oct 5, 2023

Describe your changes

Buf all the things.

TODO

  • Delete pull_request from gh workflow before merging

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

Signed-off-by: Eduardo Apolinario <[email protected]>
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4ee73f5) 59.44% compared to head (8c0abd3) 78.48%.
Report is 7 commits behind head on master.

❗ Current head 8c0abd3 differs from pull request most recent head 85b7cc2. Consider uploading reports for the commit 85b7cc2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4178       +/-   ##
===========================================
+ Coverage   59.44%   78.48%   +19.03%     
===========================================
  Files         637       18      -619     
  Lines       54262     1250    -53012     
===========================================
- Hits        32254      981    -31273     
+ Misses      19467      212    -19255     
+ Partials     2541       57     -2484     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 637 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pingsutw
pingsutw previously approved these changes Oct 8, 2023
eapolinario and others added 2 commits October 9, 2023 11:27
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario eapolinario merged commit 9e8a909 into master Oct 10, 2023
10 checks passed
@eapolinario eapolinario deleted the monorepo--add-buf-publish-gh-workflow branch October 10, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants