Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monorepo] Enable proxy-authorization in admin client #4189

Merged
merged 19 commits into from
Oct 11, 2023

Fix flytepropeller's getAdminClient

d2013e9
Select commit
Loading
Failed to load commit list.
Merged

[Monorepo] Enable proxy-authorization in admin client #4189

Fix flytepropeller's getAdminClient
d2013e9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 11, 2023 in 0s

59.48% (+0.03%) compared to 4a780c3

View this Pull Request on Codecov

59.48% (+0.03%) compared to 4a780c3

Details

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (4a780c3) 59.45% compared to head (d2013e9) 59.48%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4189      +/-   ##
==========================================
+ Coverage   59.45%   59.48%   +0.03%     
==========================================
  Files         638      638              
  Lines       54134    54406     +272     
==========================================
+ Hits        32183    32363     +180     
- Misses      19404    19490      +86     
- Partials     2547     2553       +6     
Files Coverage Δ
flyteidl/clients/go/admin/config.go 50.00% <ø> (ø)
flyteidl/clients/go/admin/config_flags.go 59.61% <100.00%> (-1.61%) ⬇️
...eidl/clients/go/admin/pkce/handle_app_call_back.go 95.00% <100.00%> (+1.06%) ⬆️
...dl/clients/go/admin/pkce/auth_flow_orchestrator.go 54.54% <85.71%> (-8.50%) ⬇️
flytepropeller/pkg/controller/controller.go 11.74% <0.00%> (ø)
flyteidl/clients/go/admin/client.go 84.89% <66.66%> (-2.03%) ⬇️
flyteidl/clients/go/admin/auth_interceptor.go 69.60% <66.07%> (-1.83%) ⬇️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.