Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s resolver for the gRPC client #4190

Merged
merged 18 commits into from
Oct 19, 2023

minor change

6c4dc83
Select commit
Loading
Failed to load commit list.
Merged

K8s resolver for the gRPC client #4190

minor change
6c4dc83
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 18, 2023 in 0s

59.27% (+0.20%) compared to a114769

View this Pull Request on Codecov

59.27% (+0.20%) compared to a114769

Details

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (a114769) 59.06% compared to head (6c4dc83) 59.27%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4190      +/-   ##
==========================================
+ Coverage   59.06%   59.27%   +0.20%     
==========================================
  Files         621      622       +1     
  Lines       53105    53208     +103     
==========================================
+ Hits        31365    31537     +172     
+ Misses      19240    19157      -83     
- Partials     2500     2514      +14     
Files Coverage Δ
flytepropeller/pkg/controller/controller.go 11.68% <0.00%> (-0.07%) ⬇️
flytestdlib/resolver/k8s_resolver.go 81.00% <81.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.