allow passing cluster pool to run-tests.py #4210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iaroslav Ciupin <[email protected]>
iaroslav-ciupin
force-pushed
the
cluster-pool-in-run-tests
branch
from
53ba018 to
555cb69
Compare
pingsutw
approved these changes
Oct 12, 2023
eapolinario
reviewed
Oct 12, 2023
| @@ -261,15 +263,17 @@ def run( | |||
| @click.argument("flytesnacks_release_tag") | |||
| @click.argument("priorities") | |||
| @click.argument("config_file") | |||
| @click.argument("cluster_pool_name") | |||
There was a problem hiding this comment.
is this a required argument now?
eapolinario
added a commit
that referenced
this pull request
Oct 12, 2023
This reverts commit db3a7ff. Signed-off-by: Eduardo Apolinario <[email protected]>
|
Revert in #4212 |
eapolinario
added a commit
that referenced
this pull request
Oct 13, 2023
This reverts commit db3a7ff. Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Describe your changes
Check all the applicable boxes
Screenshots
Note to reviewers