Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format go imports (flyteplugins) #4224

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Format go imports (flyteplugins) #4224

merged 1 commit into from
Oct 16, 2023

Conversation

andrewwdye
Copy link
Contributor

@andrewwdye andrewwdye commented Oct 13, 2023

Describe your changes

This change

  1. Updates boilerplate with gci go import formatting changes from Format and lint go imports with gci boilerplate#85
  2. Runs make goimports to sort go imports into exactly three sections
  3. Runs make lint to verify results

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2edc3bd) 59.52% compared to head (41ea03e) 59.37%.
Report is 2 commits behind head on master.

❗ Current head 41ea03e differs from pull request most recent head b994c5b. Consider uploading reports for the commit b994c5b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4224      +/-   ##
==========================================
- Coverage   59.52%   59.37%   -0.15%     
==========================================
  Files         639      552      -87     
  Lines       54611    39904   -14707     
==========================================
- Hits        32506    23693    -8813     
+ Misses      19543    13878    -5665     
+ Partials     2562     2333     -229     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flyteplugins/go/tasks/aws/client.go 43.75% <ø> (+2.67%) ⬆️
flyteplugins/go/tasks/aws/config.go 14.28% <ø> (+0.95%) ⬆️
flyteplugins/go/tasks/logs/logging_utils.go 89.70% <ø> (+1.61%) ⬆️
...ugins/go/tasks/pluginmachinery/bundle/fail_fast.go 84.37% <ø> (+0.59%) ⬆️
...plugins/go/tasks/pluginmachinery/catalog/client.go 87.50% <ø> (-0.60%) ⬇️
.../tasks/pluginmachinery/catalog/reader_processor.go 16.66% <ø> (+0.75%) ⬆️
.../tasks/pluginmachinery/catalog/writer_processor.go 20.83% <ø> (+0.14%) ⬆️
...go/tasks/pluginmachinery/core/template/template.go 75.00% <ø> (+0.40%) ⬆️
...go/tasks/pluginmachinery/flytek8s/config/config.go 50.00% <ø> (ø)
...tasks/pluginmachinery/flytek8s/container_helper.go 87.74% <ø> (+0.94%) ⬆️
... and 75 more

... and 493 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewwdye andrewwdye marked this pull request as draft October 13, 2023 23:19
@andrewwdye andrewwdye force-pushed the lint-imports-plugins branch from 75fd425 to b994c5b Compare October 13, 2023 23:42
@andrewwdye andrewwdye marked this pull request as ready for review October 13, 2023 23:42
@eapolinario
Copy link
Contributor

Thank you!

@eapolinario eapolinario merged commit ea02a22 into master Oct 16, 2023
35 of 36 checks passed
@eapolinario eapolinario deleted the lint-imports-plugins branch October 16, 2023 17:16
squiishyy pushed a commit to squiishyy/flyte that referenced this pull request Oct 18, 2023
Signed-off-by: Andrew Dye <[email protected]>
Signed-off-by: squiishyy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants